chore: Remove state engine #5752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this is still a work in progress. I'll need to do a lot more manual testing to make sure things aren't broken, I need to re-write the JSDoc of a lot of functions so they no longer mentions the state engine, and I'll definitely need to update a lot of tests. |
avelad
reviewed
Oct 9, 2023
The state engine mechanism, designed for the player class, was over-engineered. The structure of the class makes debugging player errors unnecessarily annoying, by obfuscating the code-patch the error followed. This changes the player to use an async-await setup for the top-level operations, laying things out much more clearly and linearly.
theodab
force-pushed
the
noMoStateEngineBranch
branch
from
1268ed1 to
edb3d72
Compare
avelad
reviewed
Oct 10, 2023
…er.EXTENSIONS_TO_MIME_TYPES_
|
Incremental code coverage: 91.12% |
|
It looks like the tests hang forever, probably because of the new mutexes. Just canceling the workflow for now to avoid wasting time, and I'll look into the tests on my local machine. |
joeyparrish
reviewed
Oct 10, 2023
…into noMoStateEngineBranch
theodab
force-pushed
the
noMoStateEngineBranch
branch
from
d18d5c8 to
0b2fca6
Compare
theodab
commented
Oct 30, 2023
…into noMoStateEngineBranch
avelad
approved these changes
Oct 31, 2023
avelad
pushed a commit
that referenced
this pull request
Oct 31, 2023
Looks like this was just introduced in #5752
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Nov 30, 2023
The state engine mechanism, designed for the player class, was over-engineered. The structure of the class makes debugging player errors unnecessarily annoying, by obfuscating the code-path the error followed, and in general has created a significant amount of technical debt. This changes the player to use an async-await setup for the top-level operations, laying things out much more cleanly and linearly. --------- Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Nov 30, 2023
Looks like this was just introduced in shaka-project#5752
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The state engine mechanism, designed for the player class, was over-engineered. The structure of the class makes debugging player errors unnecessarily annoying, by obfuscating the code-path the error followed, and in general
has created a significant amount of technical debt.
This changes the player to use an async-await setup for the top-level operations, laying things out much more cleanly
and linearly.