Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [DRAFT] Detached player initialization #5757

Closed
wants to merge 6 commits into from

Conversation

zangue
Copy link
Contributor

@zangue zangue commented Oct 9, 2023

No description provided.

zangue added 6 commits October 9, 2023 15:52
…players

This is the first step towards supporting media preload: DRM engine already
supports "detached" initialization, Streaming engine and parsers do not require
a media element to work. Thus, as a next step, we should modify the load graph
in a way that the attach node will only be executed when the player is actually
ready or instructed to push data to the source buffers. A functional
preload/"pre-attach" load graph could look like this:
[D] -> [MS] -> [P] -> [M] => [DRM] (at this point the streaming engine can start
prefetching segment since the manifest is already parsed and filtered).
This commit modifies the load graph topology and the walker steps
implementation to enable loading the player without media element
attached to it.
@avelad
Copy link
Member

avelad commented Oct 9, 2023

Sorry @zangue , I need close this PR. We are in the middle of a big player change (see #5752) and we cannot accept this PR right now. FYI @theodab is working on adding this functionality.

@avelad avelad closed this Oct 9, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: No instrumented code was changed.

@zangue
Copy link
Contributor Author

zangue commented Oct 9, 2023

@avelad That's ok, thanks for the update. And good to know this feature is coming soon.

@avelad
Copy link
Member

avelad commented Oct 9, 2023

@zangue It's in the roadmap for 4.6 https://github.com/shaka-project/shaka-player/blob/main/roadmap.md

@theodab
Copy link
Contributor

theodab commented Oct 10, 2023

@avelad That's ok, thanks for the update. And good to know this feature is coming soon.

Sorry, that change is something I had been talking about privately with @joeyparrish, but I probably should have also mentioned it publicly before starting work in case someone was working on something similar!

@zangue
Copy link
Contributor Author

zangue commented Oct 10, 2023

Sorry, that change is something I had been talking about privately with @joeyparrish, but I probably should have also mentioned it publicly before starting work in case someone was working on something similar!

No big deal, I'm glad this feature is actively being worked on eventually. I remain open to contributing in the event that any help is needed.

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 8, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants