-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [DRAFT] Detached player initialization #5757
Conversation
…players This is the first step towards supporting media preload: DRM engine already supports "detached" initialization, Streaming engine and parsers do not require a media element to work. Thus, as a next step, we should modify the load graph in a way that the attach node will only be executed when the player is actually ready or instructed to push data to the source buffers. A functional preload/"pre-attach" load graph could look like this: [D] -> [MS] -> [P] -> [M] => [DRM] (at this point the streaming engine can start prefetching segment since the manifest is already parsed and filtered).
This commit modifies the load graph topology and the walker steps implementation to enable loading the player without media element attached to it.
Incremental code coverage: No instrumented code was changed. |
@avelad That's ok, thanks for the update. And good to know this feature is coming soon. |
@zangue It's in the roadmap for 4.6 https://github.com/shaka-project/shaka-player/blob/main/roadmap.md |
Sorry, that change is something I had been talking about privately with @joeyparrish, but I probably should have also mentioned it publicly before starting work in case someone was working on something similar! |
No big deal, I'm glad this feature is actively being worked on eventually. I remain open to contributing in the event that any help is needed. |
No description provided.