fix: Revert EdgeDriver 115+ workaround #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a better workaround, specify the path to the Edge binary in your
capabilities request with:
"ms:edgeOptions": {"binary": "/usr/bin/microsoft-edge"}
JulianDomingo
approved these changes
Sep 7, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Sep 7, 2023
🤖 I have created a release *beep* *boop* --- ## [1.1.9](v1.1.8...v1.1.9) (2023-09-07) ### Bug Fixes * Revert EdgeDriver 115+ workaround ([#35](#35)) ([6df9bc2](6df9bc2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
joeyparrish
added a commit
to joeyparrish/karma-local-wd-launcher
that referenced
this pull request
Sep 7, 2023
Specify the explicit path to microsoft-edge if found, to work around MicrosoftEdge/EdgeWebDriver#102 (comment) This also incorporates shaka-project/webdriver-installer#35 to revert a previous workaround at that level.
joeyparrish
added a commit
to joeyparrish/karma-local-wd-launcher
that referenced
this pull request
Sep 7, 2023
Specify the explicit path to microsoft-edge if found, to work around MicrosoftEdge/EdgeWebDriver#102 (comment) This also incorporates shaka-project/webdriver-installer#35 to revert a previous workaround at that level.
joeyparrish
added a commit
to shaka-project/karma-local-wd-launcher
that referenced
this pull request
Sep 7, 2023
Specify the explicit path to microsoft-edge if found, to work around MicrosoftEdge/EdgeWebDriver#102 (comment) This also incorporates shaka-project/webdriver-installer#35 to revert a previous workaround at that level.
joeyparrish
added a commit
to joeyparrish/shaka-player
that referenced
this pull request
Sep 7, 2023
Specify the explicit path to microsoft-edge on Linux if found, to work around MicrosoftEdge/EdgeWebDriver#102 (comment) This also incorporates shaka-project/webdriver-installer#35 and shaka-project/karma-local-wd-launcher#60 to revert earlier workarounds and apply new ones for local test runs.
joeyparrish
added a commit
to joeyparrish/shaka-player
that referenced
this pull request
Sep 8, 2023
Specify the explicit path to microsoft-edge on Linux if found, to work around MicrosoftEdge/EdgeWebDriver#102 (comment) This also incorporates shaka-project/webdriver-installer#35 and shaka-project/karma-local-wd-launcher#60 to revert earlier workarounds and apply new ones for local test runs.
joeyparrish
added a commit
to shaka-project/shaka-player
that referenced
this pull request
Sep 8, 2023
Specify the explicit path to microsoft-edge on Linux if found, to work around MicrosoftEdge/EdgeWebDriver#102 (comment) This also incorporates shaka-project/webdriver-installer#35, shaka-project/karma-local-wd-launcher#60, and shaka-project/karma-local-wd-launcher#62 to revert earlier workarounds and apply new ones for local test runs.
joeyparrish
added a commit
to shaka-project/shaka-player
that referenced
this pull request
Sep 8, 2023
Specify the explicit path to microsoft-edge on Linux if found, to work around MicrosoftEdge/EdgeWebDriver#102 (comment) This also incorporates shaka-project/webdriver-installer#35, shaka-project/karma-local-wd-launcher#60, and shaka-project/karma-local-wd-launcher#62 to revert earlier workarounds and apply new ones for local test runs.
joeyparrish
added a commit
to shaka-project/shaka-player
that referenced
this pull request
Sep 8, 2023
Specify the explicit path to microsoft-edge on Linux if found, to work around MicrosoftEdge/EdgeWebDriver#102 (comment) This also incorporates shaka-project/webdriver-installer#35, shaka-project/karma-local-wd-launcher#60, and shaka-project/karma-local-wd-launcher#62 to revert earlier workarounds and apply new ones for local test runs.
echoy-harmonicinc
pushed a commit
to harmonicinc-com/shaka-player
that referenced
this pull request
Sep 27, 2023
Specify the explicit path to microsoft-edge on Linux if found, to work around MicrosoftEdge/EdgeWebDriver#102 (comment) This also incorporates shaka-project/webdriver-installer#35, shaka-project/karma-local-wd-launcher#60, and shaka-project/karma-local-wd-launcher#62 to revert earlier workarounds and apply new ones for local test runs. # Conflicts: # build/shaka-lab.yaml # package-lock.json # package.json
echoy-harmonicinc
pushed a commit
to harmonicinc-com/shaka-player
that referenced
this pull request
Sep 27, 2023
Specify the explicit path to microsoft-edge on Linux if found, to work around MicrosoftEdge/EdgeWebDriver#102 (comment) This also incorporates shaka-project/webdriver-installer#35, shaka-project/karma-local-wd-launcher#60, and shaka-project/karma-local-wd-launcher#62 to revert earlier workarounds and apply new ones for local test runs. # Conflicts: # build/shaka-lab.yaml # package-lock.json # package.json
echoy-harmonicinc
added a commit
to harmonicinc-com/shaka-player
that referenced
this pull request
Sep 27, 2023
* ci: Fix Chrome tests on Windows in GitHub Actions (shaka-project#5548) GitHub started installing "Chrome for Testing" builds on Windows and Mac. Unfortunately, these builds don't have support for H264 and AAC codecs, which we need in our tests. This fixes the issue by explicitly installing an official build of Chrome on Windows, to overwrite the "Chrome for Testing" build. # Conflicts: # .github/workflows/build-and-test.yaml * ci: Work around msedgedriver 115+ bug (shaka-project#5618) Specify the explicit path to microsoft-edge on Linux if found, to work around MicrosoftEdge/EdgeWebDriver#102 (comment) This also incorporates shaka-project/webdriver-installer#35, shaka-project/karma-local-wd-launcher#60, and shaka-project/karma-local-wd-launcher#62 to revert earlier workarounds and apply new ones for local test runs. # Conflicts: # build/shaka-lab.yaml # package-lock.json # package.json --------- Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a better workaround, specify the path to the Edge binary in your capabilities request with:
"ms:edgeOptions": {"binary": "/usr/bin/microsoft-edge"}
See also MicrosoftEdge/EdgeWebDriver#102 (comment)