Skip to content

Commit

Permalink
Small fixes to achieve reproducible build (#661)
Browse files Browse the repository at this point in the history
* Typo in 'npm run dummy:spec'
* 'babel' package is deprecated, remove from dependencies
* Mention that 'react-dom' also needs to be in webpack.conf; fix typo
  • Loading branch information
squadette authored and justin808 committed Jan 27, 2017
1 parent c5e968d commit ea69e3c
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ npm install --save "react-on-rails@../../react_on_rails"

When you use a relative path, be sure to run the above `npm install` command whenever you change the node package for react-on-rails.

Wihle we'd prefer to us `npm link`, we get errors. If you can figure out how to get `npm link react-on-rails` to work with this project, please file an issue or PR! This used to work with babel 5.
While we'd prefer to use `npm link`, we get errors. If you can figure out how to get `npm link react-on-rails` to work with this project, please file an issue or PR! This used to work with babel 5.

This is the error:

Expand Down Expand Up @@ -174,7 +174,7 @@ spec/dummy.
# Optionally change default selenium_firefox driver
export DRIVER=poltergeist
cd <top level>
npm dummy:spec
npm run dummy:spec
```

### Run NPM JS tests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
},
"cacheDirectories": ["node_modules", "client/node_modules"],
"dependencies": {
"babel": "^6.5.2",
"babel-cli": "^6.18.0",
"babel-core": "^6.21.0",
"babel-loader": "^6.2.10",
Expand Down
1 change: 0 additions & 1 deletion spec/dummy/client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
"main": "js/app.js",
"dependencies": {
"autoprefixer": "^6.6.1",
"babel": "^6.5.2",
"babel-cli": "^6.18.0",
"babel-core": "^6.21.0",
"babel-loader": "^6.2.10",
Expand Down

0 comments on commit ea69e3c

Please sign in to comment.