Small fixes to achieve reproducible build

[squadette]

hi,

I'm trying to achieve green tests on my machine. So far I'm unsuccessful, but I've found few issues which I'd like to fix in master to help everyone else.

Thank you,

---

This change is 

[coveralls]

Coverage remained the same at 99.294% when pulling 5fbe4a2 on squadette:for-upstream into 13cff3f on shakacode:master.

[coveralls]

Coverage remained the same at 99.294% when pulling 7d0f9e6 on squadette:for-upstream into 13cff3f on shakacode:master.

[coveralls]

Coverage remained the same at 99.294% when pulling 7d0f9e6 on squadette:for-upstream into 13cff3f on shakacode:master.

[justin808]

Some suggestions

---

Reviewed 3 of 4 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 6 unresolved discussions.

---

.gitignore, line 12 at r2 (raw file):

*.gem
/vendor/
*~

This is due to emacs probably and nothing to do with React on Rails. However, I'm OK with this if you think it's better here rather than your global gitignore.

---

CONTRIBUTING.md, line 89 at r2 (raw file):

When you use a relative path, be sure to run the above `npm install` command whenever you change the node package for react-on-rails.

While we'd prefer to us `npm link`, we get errors. If you can figure out how to get `npm link react-on-rails` to work with this project, please file an issue or PR! This used to work with babel 5.

Since we're getting typos: use not us.

---

CONTRIBUTING.md, line 144 at r2 (raw file):

    alias: {
      react: path.resolve('./node_modules/react'),
      'react-dom': path.resolve('./node_modules/react-dom'),

Why is this needed?

---

CONTRIBUTING.md, line 166 at r2 (raw file):

cd <top level>
npm run dummy:spec

correct

---

lib/generators/react_on_rails/templates/base/base/client/package.json.tt, line 17 at r2 (raw file):

  "cacheDirectories": ["node_modules", "client/node_modules"],
  "dependencies": {
    "babel": "^6.5.2",

why is babel removed? We should be locking the version of it.

---

spec/dummy/client/package.json, line 12 at r2 (raw file):

  "dependencies": {
    "autoprefixer": "^6.6.0",
    "babel": "^6.5.2",

why is babel removed? We should be locking the version of it.

---

Comments from Reviewable

[justin808]

@squadette Any update?

[squadette]

Review status: all files reviewed at latest revision, 6 unresolved discussions, some commit checks failed.

---

.gitignore, line 12 at r2 (raw file):

Previously, justin808 (Justin Gordon) wrote…

This is due to emacs probably and nothing to do with React on Rails. However, I'm OK with this if you think it's better here rather than your global gitignore.

I'll setup my global gitignore, makes sense.

---

CONTRIBUTING.md, line 144 at r2 (raw file):

Previously, justin808 (Justin Gordon) wrote…

Why is this needed?

I don't know. But In the doc it says:

Side note: It's critical to use the alias section of the webpack config to avoid a double inclusion error. This has already been done for you in the example and dummy apps, but for reference:

But in example and dummy apps it has both react and react-dom, while in .md it only mentions react. I'd also like to understand why exactly we need this special treatment.

---

lib/generators/react_on_rails/templates/base/base/client/package.json.tt, line 17 at r2 (raw file):

Previously, justin808 (Justin Gordon) wrote…

why is babel removed? We should be locking the version of it.

babel package is deprecated/no-op. It only warns about the need to use babel-cli.

https://github.com/babel/babel/blob/master/packages/babel/cli.js

---

Comments from Reviewable

[justin808]

Please rebase on top of master. I'd like to create a release today.

[justin808]

Review status: all files reviewed at latest revision, 6 unresolved discussions, some commit checks failed.

---

CONTRIBUTING.md, line 144 at r2 (raw file):

Previously, squadette (Alexey Mahotkin) wrote…

I don't know. But In the doc it says:

Side note: It's critical to use the alias section of the webpack config to avoid a double inclusion error. This has already been done for you in the example and dummy apps, but for reference:

But in example and dummy apps it has both react and react-dom, while in .md it only mentions react. I'd also like to understand why exactly we need this special treatment.

Good catch. I wonder if this is still needed. Safer to do this.

---

spec/dummy/client/package.json, line 12 at r2 (raw file):

Previously, justin808 (Justin Gordon) wrote…

why is babel removed? We should be locking the version of it.

@squadette Any idea here?

---

Comments from Reviewable

[squadette]

Updated as per discussion.

Thanks,

[coveralls]

Coverage remained the same at 99.298% when pulling 317dc5d on squadette:for-upstream into f929478 on shakacode:master.

[coveralls]

Coverage remained the same at 99.298% when pulling 317dc5d on squadette:for-upstream into f929478 on shakacode:master.

[coveralls]

Coverage remained the same at 99.298% when pulling 317dc5d on squadette:for-upstream into f929478 on shakacode:master.

[justin808]

@squadette why is babel removed?

[squadette]

'babel' is deprecated.

[justin808]

Thanks @squadette