FormatJS i18n argument parsing

[sepehr500]

Changed i18n parsing to convert ruby i18n argument syntax into FormatJS argument syntax to fix #1021

---

This change is 

[coveralls]

Coverage remained the same at ?% when pulling 1f2cb07 on sepehr500:master into a6fc8d8 on shakacode:master.

[sepehr500]

@justin808 Have you had a chance to look at this yet?

[justin808]

@sepehr500, Did we need to do anything about:

@justin808 The only edge case I can think of is if somebody actually wants to have %{ in their yml. I am trying to see if https://github.com/svenfuchs/rails-i18n handles this with an escape char or something like that, but I do not think they do.

CC: @kkak10.

[sepehr500]

@justin808 I don't think so. @kkak10 said it was not an issue and I could not find anything about escape chars in rails documentation.

[sepehr500]

The fix is easy. I will try to do it today.

On Wed, Aug 8, 2018, 8:48 AM Vianney Carel ***@***.***> wrote: Hi, this PR caused a regression on my end. In our translations we have arrays in keys like day_names, month_names and so on. Those are for rails and I'm pretty sure we don't use them in our react app, but they make our build crash: 14:35:31 client.1 | rake aborted! 14:35:31 client.1 | NoMethodError: undefined method `gsub' for #<Array:0x00005654df390550> 14:35:31 client.1 | /home/vianney/.rbenv/versions/2.3.6/gemsets/oneparkweb/gems/react_on_rails-11.0.10/lib/react_on_rails/locales_to_js.rb:112:in `block in flatten' 14:35:31 client.1 | /home/vianney/.rbenv/versions/2.3.6/gemsets/oneparkweb/gems/react_on_rails-11.0.10/lib/react_on_rails/locales_to_js.rb:107:in `each' 14:35:31 client.1 | /home/vianney/.rbenv/versions/2.3.6/gemsets/oneparkweb/gems/react_on_rails-11.0.10/lib/react_on_rails/locales_to_js.rb:107:in `each_with_object' 14:35:31 client.1 | /home/vianney/.rbenv/versions/2.3.6/gemsets/oneparkweb/gems/react_on_rails-11.0.10/lib/react_on_rails/locales_to_js.rb:107:in `flatten' Don't tell me I have to split our translation files into "server only" and "server + client" ones... 😰 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1046 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIjQp_GgtTq58cCJLJ05GvtGr8uLu-skks5uOt4KgaJpZM4SpwEC> .

-- Thanks~Sepehr Sobhani

[vcarel]

My apologizes, I moved my comment into a new issue: #1126

It would be great to have a fix today, really !