Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call to_json on string props #791

Merged

Conversation

justin808
Copy link
Member

@justin808 justin808 commented Apr 3, 2017

This bit of debugging shows the issue.

[1] (pry) #<#<Class:0x007f84e5bd19f8>>: 0> puts hash_or_string.to_json
"{\"comments\":[{\"id\":9,\"author\":\"xxx\",\"text\":\"xxxxxx\",\"created_at\":\"2017-01-11T08:14:10.296Z\",

[2] (pry) #<#<Class:0x007f84e5bd19f8>>: 0> puts hash_or_string
{"comments":[{"id":9,"author":"xxx","text":"xxxxxx","created_at":"2017-01-11T08:14:10.296Z",

We'll get the proper tests in #787.


This change is Reviewable

This bit of debugging shows the issue.

[1] (pry) #<#<Class:0x007f84e5bd19f8>>: 0> puts hash_or_string.to_json
"{\"comments\":[{\"id\":9,\"author\":\"xxx\",\"text\":\"xxxxxx\",\"created_at\":\"2017-01-11T08:14:10.296Z\",

[2] (pry) #<#<Class:0x007f84e5bd19f8>>: 0> puts hash_or_string
{"comments":[{"id":9,"author":"xxx","text":"xxxxxx","created_at":"2017-01-11T08:14:10.296Z",
nil
@robwise
Copy link
Contributor

robwise commented Apr 3, 2017

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@coveralls
Copy link

coveralls commented Apr 3, 2017

Coverage Status

Coverage increased (+0.003%) to 97.922% when pulling 17a3858 on dont-call-to-json-on-props-converted-to-string-already into 7f04afd on master.

@justin808 justin808 deleted the dont-call-to-json-on-props-converted-to-string-already branch June 4, 2017 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants