Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call to_json on string props #791

Merged
merged 2 commits into from
Apr 3, 2017
Merged

Don't call to_json on string props #791

merged 2 commits into from
Apr 3, 2017

Commits on Apr 3, 2017

  1. Don't call to_json on string props 

    This bit of debugging shows the issue.

[1] (pry) #<#<Class:0x007f84e5bd19f8>>: 0> puts hash_or_string.to_json
"{\"comments\":[{\"id\":9,\"author\":\"xxx\",\"text\":\"xxxxxx\",\"created_at\":\"2017-01-11T08:14:10.296Z\",

[2] (pry) #<#<Class:0x007f84e5bd19f8>>: 0> puts hash_or_string
{"comments":[{"id":9,"author":"xxx","text":"xxxxxx","created_at":"2017-01-11T08:14:10.296Z",
nil
    @justin808
    justin808 committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    cb210d0 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.md

    @justin808
    justin808 committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    17a3858 View commit details
    Browse the repository at this point in the history