Work around facebook/create-react-app#4053

sharils · Mar 22, 2018 · 787ca07 · 787ca07
1 parent 29ec013
commit 787ca07
Show file tree

Hide file tree

Showing 6 changed files with 850 additions and 646 deletions.
diff --git a/package.json b/package.json
@@ -3,7 +3,6 @@
   "version": "0.1.0",
   "private": true,
   "dependencies": {
-    "firebase": "^4.10.1",
     "prop-types": "^15.6.0",
     "ramda": "^0.25.0",
     "react": "^16.2.0",

diff --git a/public/index.html b/public/index.html
@@ -21,6 +21,12 @@
       Learn how to configure a non-root public URL by running `npm run build`.
     -->
     <title>React App</title>
+    <script src="https://www.gstatic.com/firebasejs/4.10.1/firebase.js"></script>
+    <script src="https://www.gstatic.com/firebasejs/4.10.1/firebase-app.js"></script>
+    <script src="https://www.gstatic.com/firebasejs/4.10.1/firebase-auth.js"></script>
+    <script src="https://www.gstatic.com/firebasejs/4.10.1/firebase-database.js"></script>
+    <script src="https://www.gstatic.com/firebasejs/4.10.1/firebase-firestore.js"></script>
+    <script src="https://www.gstatic.com/firebasejs/4.10.1/firebase-messaging.js"></script>
   </head>
   <body>
     <noscript>

diff --git a/src/firebase.js b/src/firebase.js
@@ -0,0 +1,7 @@
+const firebase = global.firebase || {
+  initializeApp: () => ({})
+  // test doesn't call auth
+};
+
+export const { initializeApp } = firebase;
+export const { auth } = firebase;
diff --git a/src/init/firebaseApp.js b/src/init/firebaseApp.js
@@ -1,6 +1,6 @@
-import * as firebase from "firebase";
 import { createAction, handleAction } from "redux-actions";
 import { call, put, select } from "redux-saga/effects";
+import * as firebase from "../firebase";
 
 const SET = "dinnerplano/firebaseApp/SET";
 

diff --git a/src/util/firebase.js b/src/util/firebase.js
@@ -1,4 +1,4 @@
-import * as firebase from "firebase";
+import * as firebase from "../firebase";
 
 export const fbIsLoginError = e => {
   if (e instanceof firebase.auth.Error) {