--pager=never does not respect --plain

[Susensio]

From version 0.24, bat --plain --pager=never <file> shows the line numbers (it should not, as I indicated plain)

bat --plain <file> shows the plain format, with pager
bat --pager=never <file> shows the line numbered format, without pager
bat --plain --pager=never <file> shows the line numbered format, without pager

I works correctly in 0.23

How did you install bat?

GitHub release

---

bat version and environment

Software version

bat 0.24.0 (fc95468)

Operating system

Linux 6.5.0-1-amd64

Command-line

bat --style=auto --diagnostic 

Environment variables

SHELL=/usr/bin/fish
PAGER=less
LESS='--incsearch -XRF --mouse --wheel-lines=3'
LANG=en_US.UTF-8
LC_ALL=<not set>
BAT_PAGER=<not set>
BAT_PAGING=<not set>
BAT_CACHE_PATH=<not set>
BAT_CONFIG_PATH=<not set>
BAT_OPTS=<not set>
BAT_STYLE=<not set>
BAT_TABS=<not set>
BAT_THEME=<not set>
XDG_CONFIG_HOME=/home/susensio/.config
XDG_CACHE_HOME=/home/susensio/.cache
COLORTERM=truecolor
NO_COLOR=<not set>
MANPAGER='sh -c '\''col -bx | sed s/‐/-/g | bat -l man -p'\'''

System Config file

Could not read contents of '/etc/bat/config': No such file or directory (os error 2).

Config file

# This is `bat`s configuration file. Each line either contains a comment or
# a command-line option that you want to pass to `bat` by default. You can
# run `bat --help` to get a list of all possible configuration options.

# Specify desired highlighting theme (e.g. "TwoDark"). Run `bat --list-themes`
# for a list of all available themes
#--theme="TwoDark"

# Enable this to use italic text on the terminal. This is not supported on all
# terminal emulators (like tmux, by default):
#--italic-text=always

# Uncomment the following line to disable automatic paging:
#--paging=never

# Uncomment the following line if you are using less version >= 551 and want to
# enable mouse scrolling support in `bat` when running inside tmux. This might
# disable text selection, unless you press shift.
#--pager="less --RAW-CONTROL-CHARS --quit-if-one-screen --mouse"

# Syntax mappings: map a certain filename pattern to a language.
#   Example 1: use the C++ syntax for Arduino .ino files
#   Example 2: Use ".gitignore"-style highlighting for ".ignore" files
#--map-syntax "*.ino:C++"
#--map-syntax ".ignore:Git Ignore"

--map-syntax '/home/*/.config/profile*:Bourne Again Shell (bash)'
--map-syntax '/home/*/.config/profile.d/*:Bourne Again Shell (bash)'
--map-syntax '/home/*/.config/bash/*:Bourne Again Shell (bash)'

Custom assets metadata

Could not read contents of '/home/susensio/.cache/bat/metadata.yaml': No such file or directory (os error 2).

Custom assets

'/home/susensio/.cache/bat' is empty

Compile time information

• Profile: release
• Target triple: x86_64-unknown-linux-gnu
• Family: unix
• OS: linux
• Architecture: x86_64
• Pointer width: 64
• Endian: little
• CPU features: fxsr,sse,sse2
• Host: x86_64-unknown-linux-gnu

Less version

> less --version 
less 590 (GNU regular expressions)
Copyright (C) 1984-2021  Mark Nudelman

less comes with NO WARRANTY, to the extent permitted by law.
For information about the terms of redistribution,
see the file named README in the less distribution.
Home page: https://greenwoodsoftware.com/less

[einfachIrgendwer0815]

This bug was introduced in commit e2bf85e (#2660).

That commit added a mutual override of --plain and --paging by using the .overrides_with method on the respective clap::Args. Therefore, when specifying --paging=never after --plain, --plain will be ignored completely. Vice versa, specifying --plain after --paging=never will override --paging=never, which results in actually activating paging when --plain is specified only once.

# these work as intended:
bat --plain <file> # plain format, paging
bat --pager=never <file> # normal styling, no paging

# these do not:
bat --plain --paging=never <file> # --plain gets overridden -> normal styling, no paging
bat --paging=never --plain <file> # --paging=never gets overridden -> plain format, paging

bat --paging=never --plain --plain <file> 
# --paging=never gets overridden but one will not notice because --plain --plain implies --paging=never

[madhur]

The workaround is to use bat -P -p for now. This one works