Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report name of missing file #441

Closed
skuhl opened this issue Dec 7, 2018 · 3 comments
Closed

Report name of missing file #441

skuhl opened this issue Dec 7, 2018 · 3 comments
Labels
feature-request New feature or request good first issue Good for newcomers

Comments

@skuhl
Copy link

skuhl commented Dec 7, 2018

If you use bat to concatenate a list of files together (i.e., bat file1.txt file2.txt ... > combined.txt), there is an error message when one of the listed files is missing:
[bat error]: No such file or directory (os error 2)

The error message should report the filename of the file that is missing to help the user identify which parameter passed to bat is missing.

If I use cat and a file is missing, the error message is:
/bin/cat: missingfile.txt: No such file or directory
@sharkdp
Copy link
Owner

sharkdp commented Dec 7, 2018

Thank you for the feedback.

Good suggestion! We should implement this.

@sharkdp sharkdp added feature-request New feature or request good first issue Good for newcomers labels Dec 7, 2018
ufuji1984 added a commit to ufuji1984/bat that referenced this issue Dec 10, 2018
@ufuji1984
Report filename if File::open return Err
bb46ada 
From issue sharkdp#441
@ufuji1984 ufuji1984 mentioned this issue Dec 10, 2018
Merged
sharkdp pushed a commit that referenced this issue Dec 11, 2018
@ufuji1984 @sharkdp
Report filename if File::open return Err
549e5d7 
From issue #441
@sharkdp
Copy link
Owner

sharkdp commented Dec 11, 2018

Fixed by @ufuji1984 in #444

@sharkdp sharkdp closed this as completed Dec 11, 2018
@sharkdp
Copy link
Owner

sharkdp commented Feb 8, 2019

Released in v0.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skuhl @sharkdp