Report filename in error message #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkdp
reviewed
Dec 11, 2018
src/inputfile.rs
Outdated
| @@ -59,7 +59,10 @@ impl<'a> InputFile<'a> { | |||
| match self { | |||
| InputFile::StdIn => Ok(InputFileReader::new(stdin.lock())), | |||
| InputFile::Ordinary(filename) => { | |||
| let file = File::open(filename)?; | |||
| let file = match File::open(filename) { | |||
There was a problem hiding this comment.
I think we could use .map_err here. Something like:
let file = File::open(filename).map_err(format!(...).into())?;There was a problem hiding this comment.
Thanks for your advice!
I tried it, but I couldn't get it built...
Seems out of my hands... 😅
62 | let file = File::open(filename).map_err(format!("{}: {}", filename, e).into())?;
| ^ not found in this scope
62 | let file = File::open(filename).map_err(|e| format!("{}: {}", filename, e).into())?;
| ^^^^^^^ cannot infer type for `F`
62 | let file = File::open(filename).map_err(|e:Error| format!("{}: {}", filename, e).into())?;
| ^^^^^^^ ------------------- found signature of `fn(errors::Error) -> _`
| |
| expected signature of `fn(std::io::Error) -> _`
62 | let file = File::open(filename).map_err(|e: std::io::Error| -> std::io::Error {format!("{}: {}", filename, e).into()})?;
| ^^^^ the trait `std::convert::From<std::string::String>` is not implemented for `std::io::Error`
There was a problem hiding this comment.
Ah, I was wrong. .into() is not needed. This should work (I'd like to add the additional quotes around the filename):
File::open(filename).map_err(|e| format!("'{}': {}", filename, e))?;and make it more concise by using map_err
|
Thanks a lot!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #441.
( And also adds filename to any other Errors from opening a file. )
I wonder if there is more concise/right way to do this, so please let me know if there is.
Thanks in advance!