Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Feature request: Add Typescripts Typings to the React Wrapper #41

Closed
lockettks opened this issue Sep 4, 2019 · 3 comments · Fixed by #125
Closed

Feature request: Add Typescripts Typings to the React Wrapper #41

lockettks opened this issue Sep 4, 2019 · 3 comments · Fixed by #125

Comments

@lockettks
Copy link

Great library- I just started using it and am enjoying it. It would be helpful to include the typings with this react wrapper project. I see that some typings were written for the original shepherd.js as part of
https://github.com/shipshapecode/shepherd/blob/master/src/js/step.js#L32-L89
but with this project I'm having to write my custom types in order to make Typescript happy.
Thanks in advance

@chuckcarpenter
Copy link
Collaborator

@lockettks glad you like it! We'd be happy to take a PR that included the typings you had to create, if you would be willing?

@lockettks
Copy link
Author

lockettks commented Sep 4, 2019 via email

@RobbieTheWagner
Copy link
Member

@lockettks we're definitely not pros at TypeScript here, but Shepherd itself should have the types, so we just need to ensure this wrapper uses them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants