Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Add prebuild script and tsconfig to generate declarations #125

Merged
merged 2 commits into from
Nov 25, 2019
Merged

Add prebuild script and tsconfig to generate declarations #125

merged 2 commits into from
Nov 25, 2019

Conversation

nathanhleung
Copy link
Contributor

@nathanhleung nathanhleung commented Nov 25, 2019

Resolves #41

Relevant issues:

Caveats:

  • Not really loving the use of ! and any, but this seems to be something that can only be resolved with 1. some refactoring of types in the upstream shepherd library or 2. some sort of explicit string check (e.g. if (type === 'next') action = tour.next) which means that every time you add a new action type to the base library, you need to add another check here, which I think goes against the spirit of this being a very lightweight, mostly independent-of-upstream wrapper, but let me know your thoughts

Alternative solutions:

  • rollup-plugin-typescript2 seems to support generating declarations, so we could also try upgrading

@RobbieTheWagner
Copy link
Member

@nathanhleung this seems fine to me. I'm also fine with updating and generating declarations, as you mentioned. Just let us know your preference!

@nathanhleung
Copy link
Contributor Author

nathanhleung commented Nov 25, 2019

@rwwagner90 If this is fine with you it's fine with me! Feel free to merge in whenever and looking forward to the next release.

@RobbieTheWagner
Copy link
Member

@chuckcarpenter I defer to you on this. Feel free to merge, if you think it's good to go.

Copy link
Collaborator

@chuckcarpenter chuckcarpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@chuckcarpenter chuckcarpenter merged commit d74736d into shepherd-pro:master Nov 25, 2019
@nathanhleung
Copy link
Contributor Author

@chuckcarpenter Awesome, thanks for LGTMing and hope you had a great thanksgiving holiday! Any idea when you'll cut the next release?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Add Typescripts Typings to the React Wrapper
3 participants