Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on various archs for gcc 12 #483

Closed
blapie opened this issue Nov 15, 2023 · 2 comments · Fixed by #599
Closed

Failures on various archs for gcc 12 #483

blapie opened this issue Nov 15, 2023 · 2 comments · Fixed by #599
Labels
arch bug test

Comments

@blapie
Copy link
Collaborator

blapie commented Nov 15, 2023

As reported in #477 some failures are observed with gcc12.

aarch64, ppc64el, and s390x fail with GCC 12 with the following error:

tanf denormal/nonnumber test : arg = -0, test = 0, correct = -0

We are able to reproduce locally on aarch64 (native build and test run).
@blapie blapie mentioned this issue Nov 15, 2023
Merged
blapie pushed a commit that referenced this issue Nov 20, 2023
@luhenry @GlassOfWhiskey @ericlove
Integrate RISC-V support (#477)
cea4434 
* Add support for the RISC-V Vector ISA
- RISC-V V 1.0 with (latest) intrinsics >=0.12.
- Enable bit manip extensions on RISC-V.
- Add RVVM*NOFMA configurations for determinism/bit-reproducibility across all architectures.

* Not supported yet
- DFT, QUAD, and GNUABI.
- Only upcoming versions of gcc (14+) have support for latest intrinsics. Will be supported when available in release version of gcc.

* CI Updates
- Add riscv64 CI on GitHub Actions.
- Add gcc (11 - #483) and llvm (17) builds on all architectures.
- Disable a few failing test variants, tracked in #484 and #485.
- Use same compiler versions across all builds.
- Add sysroot for dependencies.
- Nit: Reorder build-cross targets to group gcc/llvm per-arch together.

---------

Co-authored-by: GlassOfWhiskey <iacopo.c92@gmail.com>
Co-authored-by: Eric Love <eric.love@sifive.com>
@blapie
Copy link
Collaborator Author

blapie commented Nov 23, 2023

We are looking into this. I believe this was already reported in #439.

@blapie
Copy link
Collaborator Author

blapie commented Nov 23, 2023

First observations:

  • AFAICT only scalar tanf (u35) seems to fail, and only on the test tan(-0) == -0, mismatch in sign.
  • The issue does not occur when compiling for AArch64 with -DFORCE_AAVPCS=ON.

@blapie blapie mentioned this issue Mar 15, 2024
Closed
@luhenry luhenry mentioned this issue May 21, 2024
Open
@blapie blapie mentioned this issue Oct 24, 2024
Merged
6 tasks
@blapie blapie linked a pull request Oct 24, 2024 that will close this issue
Update gcc version from 11 to 13 in Linux GHA. #599
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch bug test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update gcc version from 11 to 13 in Linux GHA. blapie/sleef
1 participant
@blapie