more RunCommand initialization verification for TestStartBuildRunFollowLogs #49
Conversation
|
@gabemontero: GitHub didn't allow me to assign the following users: jkhelil. Note that only shipwright-io members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
release-note-none
kind/bug
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
passed once ... rerun again to hopefully see consistency |
|
passed again /assign @otaviof as well if he is interested but I'll take an lgtm from anybody :-) |
pkg/shp/cmd/build/run_test.go
Outdated
| @@ -162,7 +162,9 @@ func TestStartBuildRunFollowLog(t *testing.T) { | |||
| // the init to occur. | |||
| cmd.watchLock.Lock() | |||
| err := wait.PollImmediate(1*time.Second, 3*time.Second, func() (done bool, err error) { | |||
| if cmd.pw != nil { | |||
| // check any of the vars on RunCommand that are used in onEvent and make ser they are set; | |||
There was a problem hiding this comment.
| // check any of the vars on RunCommand that are used in onEvent and make ser they are set; | |
| // check any of the vars on RunCommand that are used in onEvent and make sure they are set; |
gabemontero
force-pushed
the
more-build-run-unit-test-panics
branch
from
d5e9da6 to
5f40421
Compare
|
spelling fix pushed @coreydaley thanks |
|
/lgtm |
Changes
Fixes #48
/kind bug
/assign @coreydaley
/assign @jkhelil
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes