Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add container registry to e2e #46

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

jkhelil
Copy link
Contributor

@jkhelil jkhelil commented Sep 28, 2021

Changes

Fixes #43

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

@gabemontero
Copy link
Member

/kind dependency-chage

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2021

@gabemontero: The label(s) kind/dependency-chage cannot be applied, because the repository doesn't have them.

In response to this:

/kind dependency-chage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Member

/kind cleanup

@openshift-ci openshift-ci bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 28, 2021
@gabemontero
Copy link
Member

the unit test failure was another timing window in the log follow test I recently added ... will open separate issue

@gabemontero
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2021
@gabemontero
Copy link
Member

I'll work on #48 in a few as this PR is getting unlucky with it

@gabemontero
Copy link
Member

hopefully #49 unblocks the unrelated unit test hiccup seen here

@openshift-merge-robot openshift-merge-robot merged commit 0ee0295 into shipwright-io:main Sep 28, 2021
@gabemontero
Copy link
Member

ok got lucky with the latest unit test run :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E Container Registry
3 participants