Use currentTarget for the element with the event listener

[DanielRuf]

Description

This PR resolves the wrong target in #793. Alternatively we could also catch e ourself, set the needed value to the one of currentTarget and call the original onClick method with e.

Type of change

Please add an "x" into the option that is relevant:

• Bug Fix 🐛 (non-breaking change which fixes an issue)
• Enhancement 🚀 (non-breaking change which adds functionality)
• Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
• Polish 💅 (Just some cleanups)
• Internal 🏠 Only relates to internal processes.

How to test it

Create any html elements in the button element for the search suggestion item and click on the element. It should correctly get the value of the element with the event listener, not one of its children.

[DanielRuf]

Attention, simulate('eventname') will be deprecated and is not recommended.

enzymejs/enzyme#218
enzymejs/enzyme#1455
enzymejs/enzyme#1551
enzymejs/enzyme#1943
enzymejs/enzyme#2080
enzymejs/enzyme#2173

[SG-Noxoreos]

Looking at the issue #793, this change was actually requested for version 6.7.0 and not for 6.8.0. But this PR is based off and points to version branch v6.8.0 instead.

This topic is a bit bigger than what was addressed here, because the implementation of the SuggestionList differs in the themes and the ios implementation does not rely on the target value at all.
See: themes/theme-ios11/pages/Browse/components/SearchField/index.jsx :: handleSubmit.
This means, while the proposed change introduces a way to modify the search query, it is currently not possible to do so in the ios theme.

[DanielRuf]

See: themes/theme-ios11/pages/Browse/components/SearchField/index.jsx :: handleSubmit.
This means, while the proposed change introduces a way to modify the search query, it is currently not possible to do so in the ios theme.

We can if the onClick portal prop is correctly set.
You are right, this change was planned / thought for 6.7.0 as we currently use 6.7.0-rc.4.

[DanielRuf]

This means, while the proposed change introduces a way to modify the search query, it is currently not possible to do so in the ios theme.

This is not a problem at all there.

[DanielRuf]

Replaced by #799