Changed the search component in theme-gmd to use the event's currentTarget propery over the target to obtain the updated query.

[DanielRuf]

Description

This PR resolves the wrong target in #793. Alternatively we could also catch e ourself, set the needed value to the one of currentTarget and call the original onClick method with e.

Type of change

Please add an "x" into the option that is relevant:

• Bug Fix 🐛 (non-breaking change which fixes an issue)
• Enhancement 🚀 (non-breaking change which adds functionality)
• Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
• Polish 💅 (Just some cleanups)
• Internal 🏠 Only relates to internal processes.

How to test it

Create any html elements in the button element for the search suggestion item and click on the element. It should correctly get the value of the element with the event listener, not one of its children.

[SG-Noxoreos]

See: themes/theme-ios11/pages/Browse/components/SearchField/index.jsx :: handleSubmit.
This means, while the proposed change introduces a way to modify the search query, it is currently not possible to do so in the ios theme.

We can if the onClick portal prop is correctly set.

In the current state the portal prop onClick, passed to the SEARCH_SUGGESTION_ITEM portal is not the actual handleSubmit, but is wrapped by a function that automatically fills out the query with the original suggestion entry. This was done to simplify its usage by not needing to pass the query to the handler, but changing the suggestion string/modifying the query is not accounted for, yet.

SInce you seem to need that I would suggest modifying the file themes/theme-ios11/pages/Browse/components/SearchField/components/SuggestionList/index.jsx in line 61 and change the code:

• from onClick: e => onClick(e, suggestion),
• to onClick: (e, q) => onClick(e, q && typeof q === 'string' ? q : suggestion),
  This will ensure that a query is always passed to the handleSubmit function, while it can still be overridden if needed.

[DanielRuf]

Im currently trying onClick={onClick} ' but so far it differs between ios and gmd theme so it does not work to call onClick, e, text) by default (we set a different phrase). It should be completely passed through so we can use it like in the gmd theme. Same component code work in gmd but not ios theme.

[DanielRuf]

But this is not the problem described in this PR. The problem is the wrong target. Let's discuss the other issue when this is handled (separate issue, already reported in the Slack channel).

[DanielRuf]

As already written in the Slack channel onClick: onClick would be correct as it seems.

[SG-Noxoreos]

As already written in the Slack channel onClick: onClick would be correct as it seems.

It would not fit our requirements to make the query optional. My suggested code change does fit that requirement and leaves room to modify the query as well.

But this is not the problem described in this PR. The problem is the wrong target. Let's discuss the other issue when this is handled (separate issue, already reported in the Slack channel).

Of course you can deal with this in a different scope.