Skip to content

Commit

Permalink
fix: log unknown errors to err instead of detail (#2545)
Browse files Browse the repository at this point in the history
  • Loading branch information
bryanoltman authored Oct 16, 2024
1 parent c393113 commit 5aedab5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ Engine • revision ${shorebirdEnv.shorebirdEngineRevision}''');
return ExitCode.usage.code;
} catch (error, stackTrace) {
logger
..detail('$error')
..err('$error')
..detail('$stackTrace');
exitCode = ExitCode.software.code;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ Engine • revision $shorebirdEngineRevision''',
await runWithOverrides(
() => commandRunner.run(['release', 'android', '--verbose']),
);
verify(() => logger.detail(any(that: contains('Bad state')))).called(1);
verify(() => logger.err(any(that: contains('Bad state')))).called(1);
verify(() => logger.detail(any(that: contains('#0')))).called(1);
});

Expand Down

0 comments on commit 5aedab5

Please sign in to comment.