Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log unknown errors to err instead of detail #2545

Merged
merged 2 commits into from
Oct 16, 2024
Merged

fix: log unknown errors to err instead of detail #2545

merged 2 commits into from
Oct 16, 2024
+2 −2

Conversation

bryanoltman
Copy link
Contributor

Description

Fixes #2544

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 🧪 Tests

@codecov Codecov
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@bryanoltman bryanoltman mentioned this pull request Oct 16, 2024
Closed
@bryanoltman bryanoltman merged commit 5aedab5 into main Oct 16, 2024
11 checks passed
@bryanoltman bryanoltman deleted the bo/print-unknown-errors branch October 16, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

@eseidel eseidel Awaiting requested review from eseidel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: error messages sometimes not showing in CLI
2 participants
@bryanoltman @felangel