fix: version should only log the version messages (#2262)

shorebirdtech · Jun 18, 2024 · fb16468 · fb16468
1 parent 0bacde2
commit fb16468
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/packages/shorebird_cli/lib/src/shorebird_cli_command_runner.dart b/packages/shorebird_cli/lib/src/shorebird_cli_command_runner.dart
@@ -195,6 +195,7 @@ ${lightCyan.wrap('shorebird release android -- --no-pub lib/main.dart')}''';
 Shorebird $packageVersion • git@github.com:shorebirdtech/shorebird.git
 $shorebirdFlutterPrefix • revision ${shorebirdEnv.flutterRevision}
 Engine • revision ${shorebirdEnv.shorebirdEngineRevision}''');
+      exitCode = ExitCode.success.code;
     } else {
       try {
         exitCode = await super.runCommand(topLevelResults);

diff --git a/packages/shorebird_cli/test/src/shorebird_cli_command_runner_test.dart b/packages/shorebird_cli/test/src/shorebird_cli_command_runner_test.dart
@@ -196,6 +196,7 @@ ${lightCyan.wrap("shorebird release android '--' --no-pub lib/main.dart")}''',
           () => commandRunner.run(['--version']),
         );
         expect(result, equals(ExitCode.success.code));
+
         verify(
           () => logger.info(
             '''
@@ -204,6 +205,10 @@ Flutter $flutterVersion • revision $flutterRevision
 Engine • revision $shorebirdEngineRevision''',
           ),
         ).called(1);
+
+        // Making sure the only thing that was logged was the version info.
+        // https://github.com/shorebirdtech/shorebird/issues/2260
+        verifyNever(() => logger.info(any()));
       });
     });