Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: version should only log the version messages #2262

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

erickzanardo
Copy link
Contributor

Description

shorebird --version was not properly setting the correct ExitCode and was being interpreted as failing, which would lead the CLI to print the open issue message.

This PR fixes that.

Fixes #2260

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 🧪 Tests

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0bacde2) to head (51ee959).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2262   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          186       186           
  Lines         5861      5862    +1     
=========================================
+ Hits          5861      5862    +1     
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erickzanardo erickzanardo merged commit fb16468 into main Jun 18, 2024
11 checks passed
@erickzanardo erickzanardo deleted the fix/version-messages branch June 18, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: cli shorebird --version "thinks" it is broken when it is not
2 participants