Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shorebird preview fails to detect app_id when run with an app that uses flavors #1542

Closed
bryanoltman opened this issue Nov 28, 2023 · 0 comments · Fixed by #1543
Closed

shorebird preview fails to detect app_id when run with an app that uses flavors #1542

bryanoltman opened this issue Nov 28, 2023 · 0 comments · Fixed by #1543
Assignees
Labels
bug Something isn't working

Comments

@bryanoltman
Copy link
Contributor

Description

#1530 assumes that an app has a single id, which is not true for apps with flavors. Running shorebird preview without specifying an app id in an app with flavors will attempt to use the main app id, which may not have a release.

The fix will likely be to skip app id autodetection if flavors are present.

Steps To Reproduce

  1. Run shorebird init --force in the flavors sample project
  2. Run shorebird release android --flavor stable
  3. Run shorebird preview
  4. See "No previewable releases found"
@bryanoltman bryanoltman added the bug Something isn't working label Nov 28, 2023
@bryanoltman bryanoltman moved this to In Progress in iOS Beta Nov 29, 2023
@bryanoltman bryanoltman self-assigned this Nov 29, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in iOS Beta Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
1 participant