Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shorebird_cli): only use shorebird.yaml app_id when no flavors are present #1543

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

bryanoltman
Copy link
Contributor

Description

Because each flavor has its own app id, we can only infer an app id to preview from a shorebird.yaml file that doesn't have flavors.

Fixes #1542

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (036eeee) 100.00% compared to head (5945285) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1543   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          154       154           
  Lines         4765      4768    +3     
=========================================
+ Hits          4765      4768    +3     
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman bryanoltman merged commit f9e3834 into main Nov 29, 2023
8 checks passed
@bryanoltman bryanoltman deleted the bo/preview-flavors branch November 29, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shorebird preview fails to detect app_id when run with an app that uses flavors
2 participants