fix(shorebird_cli): don't copy directory before zipping

[bryanoltman]

Description

I'm not sure why we were copying this in the first place, but this fixes the issue described in #1610.

Fixes #1610

Type of Change

• ✨ New feature (non-breaking change which adds functionality)
• 🛠️ Bug fix (non-breaking change which fixes an issue)
• ❌ Breaking change (fix or feature that would cause existing functionality to change)
• 🧹 Code refactor
• ✅ Build configuration change
• 📝 Documentation
• 🗑️ Chore

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86cba52) 100.00% compared to head (a5a7c0c) 100.00%.

❗ Current head a5a7c0c differs from pull request most recent head c1f325a. Consider uploading reports for the commit c1f325a to get more accurate results

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #1612   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          155       155           
  Lines         4826      4825    -1     
=========================================
- Hits          4826      4825    -1     

Flag	Coverage Δ
shorebird_cli	100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eseidel]

lgtm. But I would encourage you to track down more about when this broke?

Also, can we test this?

[bryanoltman]

lgtm. But I would encourage you to track down more about when this broke?

Also, can we test this?

Good call, added a test

[bryanoltman]

lgtm. But I would encourage you to track down more about when this broke?
Also, can we test this?

Good call, added a test

brendan-duncan/archive@06ff8a8 seems to be the commit in package:archive that introduced this error, which was released in their 3.4.10 release yesterday, which explains why we weren't previously seeing this.