Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: track pubspec.lock files #1613

Merged
merged 3 commits into from
Jan 3, 2024
Merged

chore: track pubspec.lock files #1613

merged 3 commits into from
Jan 3, 2024

Conversation

bryanoltman
Copy link
Contributor

Description

This will let us have a better idea of when our deps change, which may make it easier to track down the causes of bugs. Motivated by #1612.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@bryanoltman
Copy link
Contributor Author

Note: I didn't do this in package:scoped because there's a chance that might end up on pub.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bcb2c57) 100.00% compared to head (b2bdd90) 100.00%.

❗ Current head b2bdd90 differs from pull request most recent head bccc7ed. Consider uploading reports for the commit bccc7ed to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1613   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          155       155           
  Lines         4825      4825           
=========================================
  Hits          4825      4825           
Flag Coverage Δ
redis_client 100.00% <ø> (ø)
shorebird_cli 100.00% <ø> (ø)
shorebird_code_push_client 100.00% <ø> (ø)
shorebird_code_push_protocol 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on only doing this for the CLI since we probably don't want to lock deps for packages like redis_client, shorebird_code_push etc.

https://dart.dev/guides/libraries/private-files

@bryanoltman
Copy link
Contributor Author

Thoughts on only doing this for the CLI since we probably don't want to lock deps for packages like redis_client, shorebird_code_push etc.

https://dart.dev/guides/libraries/private-files

Yep, makes sense. Wanted to do this to be thorough, but I imagine we'll catch everything that changes as a transitive dependency in shorebird_cli's pubspec.lock.

@bryanoltman bryanoltman enabled auto-merge (squash) January 3, 2024 17:56
@bryanoltman bryanoltman merged commit 8b252d3 into main Jan 3, 2024
6 checks passed
@bryanoltman bryanoltman deleted the bo/track-pubspec-lock branch January 3, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants