Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move windsock CI testing into nextest to take advantage of its test sharding for huge CI runtime wins.
libtest is the default test harness used by cargo.
Custom test and benchmark frameworks can reimplement the libtest CLI API in order to be called by
cargo test
.Both tests and benchmarks follow this same libtest API.
This allows benchmarks to be run as tests, when run as a test a benchmark usually only performs one iteration to complete the test run as quickly as possible.
nextest follows this same libtest API in order to call the default libtest api and any other test framework compatible with libtest.
But in order to support being run by nextest you only need to implement a small subset of libtest's API.
Since we dont use
cargo test
anymore, we can instead just target nextests's subset of the API for a much simpler implementation.This subset is documented here.
This PR implements the libtest subset needed by nextest and then swaps our CI over to running windsock via nextest instead of through windsock.
There are still some extra windsock test cases left around as they are not compatible through the nextest test runner.
Results
With this PR CI takes the same amount of time as before.
Previously the windsock workflow took 45mins and the integration test workflow took 35mins.
Now thats swapped and the windsock workflow takes 35mins while the integration test workflow take 45mins.
However this sets up for a large win once we make use of more parallelization in the integration test workflow by #1299