Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windsock: nextest compatibility #1295

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Conversation

rukai
Copy link
Member

@rukai rukai commented Aug 17, 2023

Move windsock CI testing into nextest to take advantage of its test sharding for huge CI runtime wins.

libtest is the default test harness used by cargo.
Custom test and benchmark frameworks can reimplement the libtest CLI API in order to be called by cargo test.
Both tests and benchmarks follow this same libtest API.
This allows benchmarks to be run as tests, when run as a test a benchmark usually only performs one iteration to complete the test run as quickly as possible.

nextest follows this same libtest API in order to call the default libtest api and any other test framework compatible with libtest.
But in order to support being run by nextest you only need to implement a small subset of libtest's API.
Since we dont use cargo test anymore, we can instead just target nextests's subset of the API for a much simpler implementation.
This subset is documented here.

This PR implements the libtest subset needed by nextest and then swaps our CI over to running windsock via nextest instead of through windsock.
There are still some extra windsock test cases left around as they are not compatible through the nextest test runner.

Results

With this PR CI takes the same amount of time as before.
Previously the windsock workflow took 45mins and the integration test workflow took 35mins.
Now thats swapped and the windsock workflow takes 35mins while the integration test workflow take 45mins.

However this sets up for a large win once we make use of more parallelization in the integration test workflow by #1299

@rukai rukai force-pushed the windsock_nextest_compatible branch from 516ce99 to 621e5ce Compare August 17, 2023 06:18
@rukai rukai mentioned this pull request Aug 17, 2023
@rukai rukai force-pushed the windsock_nextest_compatible branch 3 times, most recently from ccbb89c to 696d85d Compare August 17, 2023 07:05
@rukai rukai force-pushed the windsock_nextest_compatible branch from 696d85d to 83eb676 Compare August 22, 2023 01:46
@rukai rukai marked this pull request as ready for review August 22, 2023 02:44
@rukai rukai requested a review from conorbros August 22, 2023 02:44
@rukai rukai mentioned this pull request Aug 22, 2023
@rukai rukai enabled auto-merge (squash) August 22, 2023 23:31
@rukai rukai merged commit 10052e0 into shotover:main Aug 22, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants