Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windsock move to bench #1297

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Conversation

rukai
Copy link
Member

@rukai rukai commented Aug 17, 2023

This PR:

  • Moves windsock to be a cargo bench instead of a cargo example.
  • Uses the prebuilt shotover that cargo benches get access to skip the step of running cargo build in every windsock benchmark.
    • This should save about 0.5s per bench.
    • As a result we can delete shotover-proxy/build.rs as we no longer need access to PROFILE.

In order to ensure we always call with_bin to use the prebuilt shotover, I moved shotover startup into a new shotover_process helper.

@rukai rukai force-pushed the windsock_move_to_bench branch 4 times, most recently from e30a64b to 2fc3873 Compare August 17, 2023 07:56
@rukai rukai marked this pull request as ready for review August 17, 2023 07:59
@conorbros conorbros merged commit 26cf890 into shotover:main Aug 22, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants