Fix redis_int_tests::passthrough_redis_down on macos #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
fix_passthrough_redis_down_on_macos
branch
from
01651ca
to
7ff5c5c
Compare
conorbros
approved these changes
May 8, 2024
justinweng-instaclustr
approved these changes
May 10, 2024
ronycsdu
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
progress towards #1615
the test
passthrough_redis_downasserts that a specific error is returned by shotover when the redis instance is down.Since mac os and linux have different error codes for connection refused the test passes on linux but fails on macos.
This PR fixes the test to also run on macos.
This is done by having a constant included into the assertion that is equal to
61on macos and equal to111on all other OSs.There are probably other OSs that this doesnt fix but thats fine, at this time we only care about linux and macos.