[pull] master from mozilla:master #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…the UI (bug 1854991)
and simplify the way to handle the different types of editors.
[Editor] Slightly postpone the move in the DOM in order to not block the UI (bug 1854991)
[Editor] Remove the class fooEditing from the layer when destroying it
…cessibilityData (bug 1855157)
[Editor] Don't try to add data to the struct tree when there is no accessibilityData (bug 1855157)
The old pre-processor used for CSS, and HTML, files leaves comments intact which unnecessarily contributes to the overall size of the *built* CSS files (note that the built JavaScript files don't include comments). Rather than trying to "hack" comment removal into the pre-processor it seems easier to use a PostCSS plugin instead. The one potential issue is that it also affects *some* whitespaces, and it's not clear to me if this'll work with the various CSS-related tests that run in mozilla-central. Please refer to https://www.npmjs.com/package/postcss-discard-comments for additional information.
…015 follow-up) When PR 17015 removed the `disabled` handling for the "Save"-button it left a bunch of now unused CSS rules behind, which seems like a simply oversight. Rather than shipping "dead" CSS rules, let's remove those until such a time that they're actually needed.
…sizing [Editor] Disabled the alt-text button when the editor is being resized
[Editor] Remove unused CSS rules for the altText "Save"-button (PR 17015 follow-up)
[Editor] Clear the different timeouts when destroying
StructParents entry isn't required on pages with no tagged contents (bug 1855641)
[Editor] Disable pointer events in the parent layer while an editor is resized
Remove comments from the *built* CSS files
Given that this is accessed multiple times per page in the viewer, that leads to a number of (strictly speaking unneeded) function calls and allocated Objects for each invocation. By converting `layerProperties` to a, lazily initialized, Object we can avoid this.
This also required updating the `postinstall`-step to account for recent changes in Puppeteer.
Make downloadManager optional in JSDoc types
Update Puppeteer to the latest version
Convert `layerProperties` to an Object (PR 15811 follow-up)
[Editor] Remove almost all the waitForTimeout from the freetext integration tests
Fix integration tests on Mac
… the page Note that we must append the textLayer to the DOM *before* enabling the `highlighter` and `accessibilityManager`, to avoid breaking e.g. a pending searching operation. The least invasive solution, that I was able to come up with, is to introduce a new `TextLayerBuilder` callback-function for this purpose.
Use CSS nesting in the textLayer
Use CSS nesting in the annotationLayer
… modules (PR 17055 follow-up) This patch also changes most examples to use "top level await", since that's now supported and slightly simplifies the code.
- Remove the `errorWrapper`-element, since it simplifies the example and is consistent with the default viewer; see PR 15533. - Simplify the l10n-handling, since the `NullL10n` should be able to translate everything e.g. without fallback values; see PR 17146.
…modules (PR 17055 follow-up) *Please note:* While following the steps in the README still works with this patch, in the sense that the example runs and successfully renders a PDF document, I unfortunately cannot tell if it illustrates Webpack best practices.
Fix `WidgetAnnotationElement._getKeyModifier` to account for Linux
There are environments that include *incomplete* polyfills for the `navigator`-object, which may thus cause the PDF.js library to break. Despite that clearly not being our fault, it may still result in bug reports filed against the PDF.js project; see e.g. 15728. Currently this even seem to affect *the latest* version of Node.js; see e.g. [here]. *Please note:* Thanks to the pre-processor none of these changes affect the Firefox PDF Viewer, however it does add "overhead" when working with and reviewing the affected code (which is why I'm not crazy about this).
This commit tweaks the Fluent linter workflow to match the other workflow files we have, so we make sure the steps have a newline between them for better readability and align names and descriptions of steps with how they are called in the other workflow files we have.
The current stable version of Python is Python 3.12, see https://www.python.org/downloads, so we should switch to that since Python 3.10 is older and only receives security updates.
…ent linter I noticed the following warning in the GitHub Actions workflow logs: `Configuration file not found: .github/linter_config.yml` The configuration file is called `fluent_linter_config.yml` instead, so this commit fixes the path so it points to the correct file. Fixes 487816b.
Update the GitHub Actions workflow for the Fluent linter
This major version mainly involves not using Node.js 16 internally anymore, which will be end of life on September 11th. This prevents the workflows from using an unsupported version of Node.js as well as deprecation warnings getting printed in the workflow logs. For more information please refer to https://github.com/actions/setup-node/releases/tag/v4.0.0 and actions/setup-node#850.
Update the `examples/`-folder to account for outputting of JavaScript modules (PR 17055 follow-up)
Handle appending consistently in the xfaLayer regardless of rendering intent (PR 17177 follow-up)
Pause translation when appending the textLayer and structTreeLayer to the page
Upgrade `setup-node` to version 4 in the GitHub Actions workflows
Guard `navigator`-object accesses in `src/`-files (issue 15728)
Update dependencies and translations to the most recent versions
Fix the intermittent failures with PageOpen/PageClose test
[Editor] Don't steal the keyboard events when editing mode is enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )