Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change directory paths to be compatible with the streaming integrator #55

Merged
merged 4 commits into from
Jul 19, 2019

Conversation

BuddhiWathsala
Copy link
Contributor

Purpose

Resolve #52

Approach

Get the paths from the siddhi-operator-config config map. Those paths are siddhiHome and siddhiProfile. Change the image name to siddhiRunnerImage -> siddhiImage to be consistent with namings in the config map. By default, we have the bin/ directory and wso2/ directory hardcoded. The paths are populated like below.

  • path to the sh file = {SiddhiHome} + "bin/" + {SiddhiProfile} + ".sh"
  • file persistence path = {SiddhiHome} + {SiddhiProfile} + "/siddhi-app-persistence"

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Change artifacts_test.go and utils_test.go

Test environment

minikube version: v1.2.0

Copy link
Contributor

@pcnfernando pcnfernando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the requested

@pcnfernando pcnfernando merged commit 90a01ca into siddhi-io:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot deploy WSO2 Streaming Integrator image with different path
3 participants