Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the code and address minor fixes #123

Merged
merged 5 commits into from
Dec 13, 2019
Merged

Refactor the code and address minor fixes #123

merged 5 commits into from
Dec 13, 2019

Conversation

BuddhiWathsala
Copy link
Contributor

Purpose

$subject

Approach

  • Use path package
  • Use Sprint and remove fake client
  • Add explicit return variables
  • Add a common variable to parser name
  • Clean if statements

Related PRs

Test environment

minikube version: v1.4.0
K8s client version v1.11.3
K8s server version v1.16.0

@mohanvive mohanvive merged commit f46165a into siddhi-io:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanvive mohanvive mohanvive approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BuddhiWathsala @mohanvive