Enable version controlling for config map changes #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Approach
Previously we have enabled the version controlling in SiddhiProcess level. In SiddhiProcess deployments, user can specify SiddhiApps as config maps. If the user changes the given config map that change is not visible for SiddhiProcess. Therefore SiddhiProcess does not change.
Here we add a primary watch function for config maps. From that, if someone changes the config map, the reconcile loop will trigger. We maintain an internal mapping for config map to SiddhiProcess. From that, we can identify the SiddhiProcess that we need to update when config map changes. Then the previous updating process of #57 continues the execution.
User stories
User can change stateful -> stateless and stateless->stateful without any problem. The operator will create remaining K8s artifacts in stateless->stateful scenario. Also, the operator will remove unwanted K8s artifacts in stateful -> stateless scenario.
Related PRs
Test environment