Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Turing RK1 SoM to SBCs dropdown #753

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

nberlee
Copy link
Contributor

@nberlee nberlee commented Dec 3, 2024

I think sbc overlays could be queried from the factory api like the talos version already is.

But I simply wanted to add the turing rk1 and cannot allocate the time to implement it correct

@smira smira requested a review from Unix4ever December 5, 2024 15:16
@Unix4ever
Copy link
Member

Do we support this board for Talos 1.7 and 1.8?
Asking that because we might need to introduce a new check, which will disable the SBC for the old versions of Talos.

@nberlee
Copy link
Contributor Author

nberlee commented Dec 9, 2024

No, its it needs kernel 6.12. So starting from 1.9

@smira smira mentioned this pull request Dec 9, 2024
@Unix4ever
Copy link
Member

I will add a couple changes to your PR to support limiting the min supported Talos version for some configurations.

@Unix4ever Unix4ever force-pushed the main branch 2 times, most recently from d74497d to 8a1fb40 Compare December 10, 2024 15:44
@Unix4ever
Copy link
Member

Ok, updated. Now Turing RK1 will only be available for Talos 1.9.x+.

Screenshot 2024-12-10 at 22 45 15

This has hardcoded "turingrk1" strings as discussed in
siderolabs/talos#9869

Signed-off-by: Nico Berlee <nico.berlee@on2it.net>
Signed-off-by: Artem Chernyshev <artem.chernyshev@talos-systems.com>
@nberlee
Copy link
Contributor Author

nberlee commented Dec 10, 2024

Ty @Unix4ever

@Unix4ever
Copy link
Member

Thank you for the PR :)

@Unix4ever
Copy link
Member

/m

@talos-bot talos-bot merged commit bbbf6f2 into siderolabs:main Dec 10, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants