Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unifying protobuf/grpc codec implementation #9404

Closed
9 tasks done
smira opened this issue Sep 30, 2024 · 2 comments · Fixed by siderolabs/omni#681, siderolabs/grpc-proxy#23, siderolabs/grpc-proxy#24, siderolabs/discovery-service#69 or #9424
Closed
9 tasks done

unifying protobuf/grpc codec implementation #9404

smira opened this issue Sep 30, 2024 · 2 comments · Fixed by siderolabs/omni#681, siderolabs/grpc-proxy#23, siderolabs/grpc-proxy#24, siderolabs/discovery-service#69 or #9424
Assignees
@DmitriyMV

Comments

@smira
Copy link
Member

smira commented Sep 30, 2024 •
edited by DmitriyMV
Loading

  • Update services
    • Discovery Service
    • Talos
    • Omni
  • grpc CodecV2
  • Support proto interfaces
    • protobuf
    • gogo
    • vtprotobuf
@DmitriyMV DmitriyMV mentioned this issue Oct 2, 2024
Merged
DmitriyMV added a commit to DmitriyMV/talos that referenced this issue Oct 2, 2024
@DmitriyMV
chore: add proto-codec/codec
763a545 
Unify usage of proto codec v2 across our projects.

For siderolabs#9404

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
@DmitriyMV DmitriyMV mentioned this issue Oct 2, 2024
Merged
DmitriyMV added a commit to DmitriyMV/talos that referenced this issue Oct 2, 2024
@DmitriyMV
chore: add proto-codec/codec
e25011a 
Unify usage of proto codec v2 across our projects.

For siderolabs#9404

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/talos that referenced this issue Oct 2, 2024
@DmitriyMV
chore: add proto-codec/codec
2f156b3 
Unify usage of proto codec v2 across our projects.

For siderolabs#9404

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
@DmitriyMV
Copy link
Member

We should update grpc-proxy too.

DmitriyMV added a commit to DmitriyMV/talos that referenced this issue Oct 10, 2024
@DmitriyMV
chore: add proto-codec/codec
a459ca1 
Unify usage of proto codec v2 across our projects.

For siderolabs#9404

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to siderolabs/omni that referenced this issue Oct 10, 2024
@DmitriyMV
chore: move from Codec to CodecV2
d41a4d4 
This should be protocol backward compatible change (and breaking change in the source code) which should speed-up the process of gRPC
data encoding / decoding. Also unify our CodecV2 usage.

For siderolabs/talos#9404

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
@DmitriyMV DmitriyMV mentioned this issue Oct 10, 2024
Merged
DmitriyMV added a commit to DmitriyMV/omni that referenced this issue Oct 10, 2024
@DmitriyMV
chore: move from Codec to CodecV2
99731a6 
This should be protocol backward compatible change (and breaking change in the source code) which should speed-up the process of gRPC
data encoding / decoding. Also unify our CodecV2 usage.

For siderolabs/talos#9404

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/omni that referenced this issue Oct 10, 2024
@DmitriyMV
chore: move from Codec to CodecV2
ac09eef 
This should be protocol backward compatible change (and breaking change in the source code) which should speed-up the process of gRPC
data encoding / decoding. Also unify our CodecV2 usage.

For siderolabs/talos#9404

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/omni that referenced this issue Oct 10, 2024
@DmitriyMV
chore: move from Codec to CodecV2
7b0273c 
This should be protocol backward compatible change (and breaking change in the source code) which should speed-up the process of gRPC
data encoding / decoding. Also unify our CodecV2 usage.

For siderolabs/talos#9404

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/omni that referenced this issue Oct 10, 2024
@DmitriyMV
chore: move from Codec to CodecV2
7bf49de 
This should be protocol backward compatible change (and breaking change in the source code) which should speed-up the process of gRPC
data encoding / decoding. Also unify our CodecV2 usage.

For siderolabs/talos#9404

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/omni that referenced this issue Oct 11, 2024
@DmitriyMV
chore: move from Codec to CodecV2
115e166 
This should be protocol backward compatible change (and breaking change in the source code) which should speed-up the process of gRPC
data encoding / decoding. Also unify our CodecV2 usage.

For siderolabs/talos#9404

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/omni that referenced this issue Oct 11, 2024
@DmitriyMV
chore: move from Codec to CodecV2
b8fb910 
This should be protocol backward compatible change (and breaking change in the source code) which should speed-up the process of gRPC
data encoding / decoding. Also unify our CodecV2 usage.

For siderolabs/talos#9404

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/omni that referenced this issue Oct 11, 2024
@DmitriyMV
chore: move from Codec to CodecV2
d7a7375 
This should be protocol backward compatible change (and breaking change in the source code) which should speed-up the process of gRPC
data encoding / decoding. Also unify our CodecV2 usage.

For siderolabs/talos#9404

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/omni that referenced this issue Oct 11, 2024
@DmitriyMV
chore: move from Codec to CodecV2
3c753cf 
This should be protocol backward compatible change (and breaking change in the source code) which should speed-up the process of gRPC
data encoding / decoding. Also unify our CodecV2 usage.

For siderolabs/talos#9404

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/omni that referenced this issue Oct 12, 2024
@DmitriyMV
chore: move from Codec to CodecV2
a3bf2ea 
This should be protocol backward compatible change (and breaking change in the source code) which should speed-up the process of gRPC
data encoding / decoding. Also unify our CodecV2 usage.

For siderolabs/talos#9404

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/omni that referenced this issue Oct 12, 2024
@DmitriyMV
chore: move from Codec to CodecV2
3f38d89 
This should be protocol backward compatible change (and breaking change in the source code) which should speed-up the process of gRPC
data encoding / decoding. Also unify our CodecV2 usage.

For siderolabs/talos#9404

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/omni that referenced this issue Oct 15, 2024
@DmitriyMV
chore: move from Codec to CodecV2
1544b9c 
This should be protocol backward compatible change (and breaking change in the source code) which should speed-up the process of gRPC
data encoding / decoding. Also unify our CodecV2 usage.

For siderolabs/talos#9404

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
This was linked to pull requests Oct 16, 2024
chore: move from Codec to CodecV2 siderolabs/omni#681
Merged
chore: upgrade Codec implementations and usages to Codec2 siderolabs/grpc-proxy#23
Merged
fix: copy data from big frame msg siderolabs/grpc-proxy#24
Merged
chore: add proto-codec/codec siderolabs/discovery-service#69
Merged
DmitriyMV added a commit to DmitriyMV/talos that referenced this issue Oct 16, 2024
@DmitriyMV
chore: add proto-codec/codec
9e45a0d 
Unify usage of proto codec v2 across our projects.

For siderolabs#9404

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/talos that referenced this issue Oct 16, 2024
@DmitriyMV
chore: add proto-codec/codec
59a78da 
Unify usage of proto codec v2 across our projects.
Bump grpc library to 1.67.1 and ensure that we it still works with HTTP/2 ALPN value changes.

For siderolabs#9404

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
@DmitriyMV DmitriyMV linked a pull request Oct 16, 2024 that will close this issue
chore: add proto-codec/codec #9424
Merged
@DmitriyMV
Copy link
Member

With talos PR merged, this is now closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DmitriyMV DmitriyMV

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@smira @DmitriyMV