Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve catch-all network interface deviceSelector. #8090

Closed
wants to merge 4 commits into from

Conversation

reitermarkus
Copy link
Contributor

Pull Request

What? (description)

Change example for catch-all network interface deviceSelector.

Why? (reasoning)

The existing example does not work on Raspberry Pi, I assume since the network interface is not a PCIe device but connected to the USB controller.

I am using Raspberry Pis (Hardware PHY) and Proxmox VMs (VirtIO PHY). The common attributes of the ethernet interfaces seem to be type: ether and kind: ''.

Acceptance

Please use the following checklist:

  • you linked an issue (if applicable)
  • you included tests (if applicable)
  • you ran conformance (make conformance)
  • you formatted your code (make fmt)
  • you linted your code (make lint)
  • you generated documentation (make docs)
  • you ran unit-tests (make unit-tests)

See make help for a description of the available targets.

@reitermarkus
Copy link
Contributor Author

Nevermind, it seems these fields are not supported in the deviceSelector config.

What is the recommended way to match the network interface on Raspberry Pis? It seems the only options are to match the driver (bcmgenet) or by a specific hardwareAddr, but then this won't match on the Proxmox VMs.

@smira
Copy link
Member

smira commented Dec 19, 2023

Nevermind, it seems these fields are not supported in the deviceSelector config.

What is the recommended way to match the network interface on Raspberry Pis? It seems the only options are to match the driver (bcmgenet) or by a specific hardwareAddr, but then this won't match on the Proxmox VMs.

Are you looking for a deviceSelector that would match across different hardware types? I guess this might be tricky, but still might be a nice feature request. We could add a match for physical interfaces (that's what you described with type: ether and kind: )

@reitermarkus
Copy link
Contributor Author

Are you looking for a deviceSelector that would match across different hardware types?

For my simple setup with only a single hardware interface per device, ideally I would not have to specify any selector and Talos should just use the only available interface.

@smira
Copy link
Member

smira commented Dec 19, 2023

you can also use net.ifnames=0 and have eth0 if you have a single interface, but the request for a simple device selector makes sense

@smira smira self-assigned this Jan 18, 2024
smira added a commit to smira/talos that referenced this pull request Jan 18, 2024
Closes siderolabs#8090

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira added a commit to smira/talos that referenced this pull request Jan 18, 2024
Closes siderolabs#8090

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
@smira
Copy link
Member

smira commented Jan 18, 2024

#8173 implements physical: true device selector.

@smira smira closed this Jan 18, 2024
smira added a commit to smira/talos that referenced this pull request Jan 23, 2024
Closes siderolabs#8090

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
@reitermarkus reitermarkus deleted the patch-1 branch May 5, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants