feat: implement device selector for 'physical' #8173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
force-pushed
the
feat/physical-device-selector
branch
from
e1803bc
to
0affc9b
Compare
7 tasks
frezbo
reviewed
Jan 21, 2024
hack/release.toml
Outdated
| [notes.device_selectors] | ||
| title = "Device Selectors" | ||
| description = """\ | ||
| Talos now supports `physical: true` qualifier for device selectors. |
There was a problem hiding this comment.
probably needs to be more clear what physcial is, like physically attached NIC's
There was a problem hiding this comment.
yep, I will clarify this, thanks
frezbo
approved these changes
Jan 21, 2024
Closes siderolabs#8090 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
force-pushed
the
feat/physical-device-selector
branch
from
0affc9b
to
d677901
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8090