-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Electron] Minimize/Close to tray #1480
Comments
It's actually a standard. Most modern messengers have it (Viber, Skype...). |
@scottnonnenberg here is something worth looking at to get this implemented, since currently the close/minimize is honestly pretty useless and it would make it easier to keep it in the tray and have it show a notification when a message comes in. https://github.com/electron/electron/blob/master/docs/api/tray.md Additionally, it would be quite trivial and yet useful thing to add an |
Maybe you could fill me on on what exactly is wrong with the current minimize behavior? Regarding the About menu - seems that our attempts to make it cross-platform have failed. There's an About entry in the File menu on OSX today. |
Currently when you click on minimize it sits on the taskbar and doesn't actually go away and takes up space when not in use so you have to choose between closing it or just having that space taken up all day. A proper and useful minimize would put it in the systray where it doesn't take up valuable space and can be accessed without closing it out until a notification comes that you got something, which would then bring up the interface when clicked. See? I can safely say that EVERY SINGLE "messenger" app out there with a desktop client has this behavior, except us. |
@GuardianMajor And to be clear, you're on Linux? I can remember this kind of thing from my Windows days, so I expect that it applies there as well. Is anyone pushing for this on OSX? |
I can speak only about tray icons on Windows/Linux as I am not so familiar with Mac: Systray icons are used for such prorams that are always running but are not used every single moment. If I look at my systray now I see Mega (sync), Viber, Syncthing and Mail on my tray (Ubuntu 17.04), so I think you get the picture. Those programs are running all the time but would clutter the taskbar if they'd just lay there. Now for Signal: different people use it differently, some would like to have it allways running, from the boot on, others would prefer to start it every single time they need it and shut it down after use. So, for a nice UX you'd need two options in settings:
Also, if you choose to bring Signal to systray it's important for notifications to show up only when the screen is on, if the screen is off they would appear on your phone. |
@scottnonnenberg No my friend, I am on Windows. Apologies for not making that clear, I realize the OP is on Linux but I didn't want to clutter the issues by adding yet another one just for Windows, given the principle is universal across all platforms. @bungabunga Correct, and since it is a messenger, having it open all day on your system while you are there is not unreasonable usage behavior and it would more than justify having it minimize to the system tray until you get a message/need to send a message/or otherwise interact with it. |
https://github.com/Enrico204/Whatsapp-Desktop |
Minimize to tray is usually a standard feature when it comes to messaging applications in Windows and have been for a long time. |
I was wondering if I had configured my fluxbox installation wrong or if signal-desktop really had no tray icon support. Please implement this. |
Just a note: it's important that notifications will work and appear the same way when the application is minimized to tray. I tried to use Signal Desktop with a 3rd party "tray iconizer" (rbtray), and when minimized, I got no visual or audio notifications. This is probably specific to how this 3rd party software works, just thought I'd share my experience with those who are experimenting with this. |
I think the common modern UI is that |
This commit adds a tray icon to the application, shown in the system tray bar, that can be used to minimise the application window. This is a common feature on most desktop messaging apps (e.g. Telegram Desktop or Slack) and allows to save space in the system task bar. The tray icon provides a context menu that contains a button to show/hide the application window, and a button to quit the application. When the tray icon is clicked, the visibility of the window is toggled. When the close (x) button of the window is pressed, the application is not terminated but minimised to the tray icon instead (it can be terminated by using the "Quit" entry in the File menu or in the context menu of the tray icon). The tray icon is disabled by default, and two command line arguments are available to enable it: --use-tray-icon: enables the tray icon --start-in-tray: enables the tray icon and the application starts minimised in the tray bar Resolves: signalapp#1480
This commit adds a tray icon to the application, shown in the system tray bar, that can be used to minimise the application window. This is a common feature on most desktop messaging apps (e.g. Telegram Desktop or Slack) and allows to save space in the system task bar. The tray icon provides a context menu that contains a button to show/hide the application window, and a button to quit the application. When the tray icon is clicked, the visibility of the window is toggled. When the close (x) button of the window is pressed, the application is not terminated but minimised to the tray icon instead (it can be terminated by using the "Quit" entry in the File menu or in the context menu of the tray icon). The tray icon is disabled by default, and two command line arguments are available to enable it: --use-tray-icon: enables the tray icon --start-in-tray: enables the tray icon and the application starts minimised in the tray bar Resolves: #1480
This would be a great feature to have on Signal. Having it run in background with a tray icon and notification badges would be the ideal experience on Windows. |
Why does this keep getting closed, rather than assigned? Clearly there is significant demand, for all operating systems. |
@LanceHaverkamp If you'd like to try the prerelease tray functionality, you can start the app with |
@scottnonnenberg Wonderful!!!!! Thanks! Not sure why my searching for this very answer was not productive, but that's exactly what I was looking for! |
How do I apply the start command to the Windows client? |
I was missing the tray option, too. Nice to see it's already there. :-) Ah, and I would like to open it with a double click instead/beside of the context menu. |
I guess you also are affected by this problem: #1876 |
Exactly. Thanks for that. It's working even so I don't have unity^ |
@paulsommer I just installed Signal on KDE as well and get an ugly white square where the tray icon should be (when adding '--start-in-tray'. Have you found a solution to this or do we just have to wait unti lthey get around to fix this? All other messaging apps I have used on KDE (FB Messenger, Slack, Viber, Telegram and Skype) had functional tray icons. I was really surprised to find that Signal isn't. I hope this will be fixed soon. |
Hmm, dunno. For me the preceeding XDG_CURRENT_DESKTOP=Unity did the trick. |
FWIW, tray startup also works on Fedora (signal installed via https://copr.fedorainfracloud.org/coprs/luminoso/Signal-Desktop/) |
I too wish there was a "Close to tray option". I keep accidentally closing it out with "X" when trying to close out of a picture. |
Didn't want to submit new ticket, but I have the same issue... Running antergos KDE and every time I start Signal (no matter if it's "normal" or tray mode), I only see empty square icon in tray, which says "Electron". I got it fixed by using "XDG_CURRENT_DESKTOP=Unity signal-desktop --start-in-tray" command, but one issue remains: clicking the icon does not bring Signal window (even if icon is displayed properly now). The only way to open Signal is to right-click tray icon and click "Show". |
|
OS: Windows 10. |
I'm running Signal desktop (beta, 1.19.0-beta.4 package) on Xfce (Debian sid) and it seems that even with --use-tray-icon Signal won't appear in the system tray (so when it's close it's still running but I can't get it back). There's a warning when starting in console but I'm unsure if it's related:
|
Running Signal desktop on Fedora 29 Xfce (4.12) via Snap package. |
The snap version does not support
...after all that, you can edit the launcher with |
Can someone edit the top post to add this info? I came across this issue TWICE before deciding to read all the way through, since it was CLOSED. |
@Biserkov these are two commands and you don't have to fire both together. to start Signal Desktop in tray the second one is enough. |
Override the GNOME shell launch default by creating
|
That still doesn't work (with 1.26.2-beta.1). Nothing appears in the systray. |
@corsac-s gnome-shell needs to be re-started for the changes to |
I don't use gnome-shell, I start from the terminal using the command in the Exec= line. The command itself doesn't work. |
Is this SERIOUSLY not an implemented feature? Holy fucking shit. I cannot believe im going to have to spend hours googling to find a third party solution for closing/minimizing to tray |
@jazir5 I am aware of the irony for saying this but instead of spamming everyone's mailbox with overt and unnecessary outrage, just read a tiny bit and you'll see no need for a third party anything, just some basic skill and common sense to modify the shortcut to launch minimized, as well as minimize to tray. Really simple really, I think they should close this topic to any more comments. |
I didn't mean to have it be sent to multiple places, apologies
…On Tue, Sep 17, 2019, 10:38 PM GµårÐïåñ ***@***.***> wrote:
@jazir5 <https://github.com/jazir5> I am aware of the irony for saying
this but instead of spamming everyone's mailbox with overt and unnecessary
outrage, just read a tiny bit and you'll see no need for a third party
anything, just some basic skill and common sense to modify the shortcut to
launch minimized, as well as minimize to tray. Really simple really, I
think they should close this topic to any more comments.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1480?email_source=notifications&email_token=AHSHPL3AKSODLN5B7J5RWD3QKG5D5A5CNFSM4D3A74JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD663MIY#issuecomment-532526627>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHSHPL5CHBUT6F4APWB5XO3QKG5D5ANCNFSM4D3A74JA>
.
|
@GuardianMajor the command line arguments don't work anymore, so editing the shortcuts won't do anything. |
@corsac-s where exactly they do not work? i use command line arguments on ubuntu and windows and they work. |
@bungabunga as indicated on #1480 (comment) I'm using Xfce (4.14 now) with their systray plugin, on Debian sid. Tray icon was working just fine until few months ago (maybe a year). |
@corsac-s as much as I hate to say this in response to people, it woks just fine for me as of this morning. Now I am on Windows if that matters, can't speak for Linux but even then it doesn't justify abusive, rude or insulting stance against the developers. Now I realize having issues on Linux would be a less than ideal situation and it is not a small group of people but it is indeed limited to specific platform right now so unfair to crap on the whole thing. Just my two cents. You have probably done this already but if not, have you opened a ticket with them so they can follow through and find out why it is not working on Linux? or your particular distro or whatnot? I don't see @scottnonnenberg and them intentionally ignoring issues affecting a decent amount of people if they were aware of it, unless it is some kind of technical limitation that is stalling them. |
So yes, it's likely using different primitives and it's not surprising that it could work on one OS and not on the other
I think that's exactly the point of that issue. Unless you mean someone else with “them”. |
Conversation deep in an already-closed issue is not the right way to make progress on anything. Clearly it works for some now, even on Linux, so a new bug with all the necessary details of the affected platforms would be great. Locking this issue now. |
Most messaging programs can be minimized to tray so they do not clutter up the taskbar, so it would be nice, if Signal could do that, too.
Since #761 Signal Desktop switched to electron so it should now be possible to implement minimizing signal to tray.
Platform info:
Operating System: Kubuntu 17.04
Signal version: 1.0.24 Electron
The text was updated successfully, but these errors were encountered: