Added option to minimize to tray

[vectorlit]

First time contributor checklist

• I have read the README and Contributor Guidelines
• I have signed the Contributor Licence Agreement

Contributor checklist

• My contribution is fully baked and ready to be merged as is
• My changes are rebased on the latest master branch
• My commits are in nice logical chunks
• I have followed the best practices in my commit messages
• I have tested my contribution on these platforms:

• OSX Sierra
• Windows 10
• Xubuntu 17.04
• Ubuntu 17.10

• My changes pass all the local tests 100%
• I have considered whether my changes need additional tests, and in the case they do, I have written them

---

Description

This commit proposes to address #1480

Added an option to minimize the application to tray. The option defaults to false on first run, but is saved according to current practices and loaded on subsequent runs.

This commit needed 4 new localization strings for the menu items.

System tray icon maintains a menu and click-behavior consistent with modern communication applications.

System tray icon has been tested on Windows, OSX, and Linux (XFCE and older versions of gnome). Newer versions of Gnome (including newest non-LTS versions of Ubuntu) do not support a system tray without modification. If this is an issue in the future, suggest adding module "getos" and maintaining a supported release list (beyond the scope of this commit).

[scottnonnenberg]

Thanks for jumping in and doing this.

First, we have another active pull request implementing a try for the app. Instead of adding a user-visible option, it starts out with just command-line arguments, which I like because it will allow us to test it before rolling out to a large set of users: #1676

Maybe we could put this one on hold, focus on finalizing and testing that one, then come back to this when we need a user-visible option?

[vectorlit]

Yeah I just saw that after I submitted the request. Typical programmer failure on my part. But actually the other pull request's code is great. Only immediate suggestion for that request to merge from mine would be to set the darwin platform icon as icon_16, as otherwise it'll be too large for the top bar on OSX.

Otherwise the options logic from this pull request should be easy to integrate (if it helps) following UAT of the other pull.

[m-pilia]

Hello @vectorlit . Thanks, I followed your suggestion to use the icon_16 on Darwin. Good to know for me since I cannot test this on macOS.

[bungabunga]

@vectorlit just a correction: the new Ubuntu 17.10 which is based on Gnome actually does support system tray. It comes with a Ubuntu AppIndicators extension preinstalled, that is a customized fork of KStatusNotifierItem/AppIndicator and enables app indicators in the top panel.

[scottnonnenberg]

I'm going to close this for now, since we won't be merging these changes anywhere close to their current form.

[ropimasi]

Excuseme, hello guys,
This feature (minimize to tray) is still working on Signal Desktop v5.0.0 ?