Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make chat text field a normal field so it supports spellchecking and Apple touchbar. #1681

Closed
peacememories opened this issue Nov 2, 2017 · 3 comments

Comments

@peacememories
Copy link

On any system, but especially in macOS a text field is normally associated with some platform features. For example, a text field allows the system spellcheck to function, and provides some options on the touchbar, etc.
It seems the message composition field of Signal Desktop disables this integration.
I would love to be able to use my normal system features in this text box, or at least to know the reason why this is not enabled.

Thanks :)

@scottnonnenberg
Copy link
Contributor

When you say 'normal field' can you give me an example of what you're talking about? An application that does the right thing?

And, just to be clear, you don't get the behavior you're talking about when you browse the web, right?

arlolra added a commit to arlolra/Signal-Desktop that referenced this issue Nov 19, 2017
@arlolra
Copy link
Contributor

arlolra commented Nov 19, 2017

It seems the message composition field of Signal Desktop disables this integration.

I don't think that's the case. Misspellings are currently underlined and the ctrl+command+spacebar emoji picker works.

There just needs to be some TouchBar integration,
https://electronjs.org/docs/api/touch-bar

I've opened #1791 as a start.

@scottnonnenberg
Copy link
Contributor

I've closed #1791 for now. Let's get clear about the current behavior and the new behavior we want.

Spell-check was mentioned, but we do have spell-check support in the app.

And the MacOS-specific ctrl+command+spacebar emoji-picker works as well, with no changes.

What exactly is the benefit of writing custom code for TouchBar support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants