Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS TouchBar integration #1791

Closed
wants to merge 2 commits into from
Closed

Conversation

arlolra
Copy link
Contributor

@arlolra arlolra commented Nov 19, 2017

For #1681

@arlolra arlolra changed the title [WIP] Add macOS TouchBar integration Add macOS TouchBar integration Nov 21, 2017
@scottnonnenberg
Copy link
Contributor

Thanks for doing this proof of concept, but I'm not convinced we need to do anything here yet.

@arlolra
Copy link
Contributor Author

arlolra commented Nov 28, 2017

😢

@GhostLyrics
Copy link

If this enables macOS's buildin spellchecker as a side effect I'm inclined to disagree. The upside of that one is that it can guess the language in use from the context if you have more than one language enabled (e.g. English and German for me).

@snuffels
Copy link

snuffels commented May 4, 2020

Touchbar support works. The correcting of spelling on the touchbar works a bit strange.
Lets take this sentence

Waht are the fetures of this sotware pakage?

and I go back to correct the words I get this:

What are the features tures of this sotware package e?

Waht was easily corrected but it addded an extra space in the end
after clicking on a couple of places fetures could be changed but it corrected the word before the cursor and added a space and left the rest of the word as it was.
It could not find a solution to sotware, thats an apple problem
And after klicking on a couple of places of pakage it came with the correct word but only changed the word before the cursor and added a space and left the 'e'.

Can this be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants