Toggle window visibility on tray icon click

[hiqua]

Fixes #3045.

Contributor checklist:

• My contribution is not related to translations. Please submit translation changes via our Signal Desktop Transifex project.
• My commits are in nice logical chunks with good commit messages
• My changes are rebased on the latest development branch
• A yarn ready run passes successfully (more about tests here)
• My changes are ready to be shipped to users

Description

Currently, (left) clicking the tray icon shows the window, but clicking again does not hide it. This change allows users to click again to hide the window.

[EvanHahn-Signal]

I think this needs to be rebased against the latest development. Unfortunately, this file was deleted, so I think you'll need to make the change here:

Signal-Desktop/app/SystemTrayService.ts

Lines 184 to 186 in 1032249

	if (!browserWindow.isVisible()) {
	browserWindow.show();
	}

I suspect this is what you'll do, but I haven't tested it:

if (browserWindow.isVisible()) {
  browserWindow.hide();
} else {
  browserWindow.show();
}

[hiqua]

@EvanHahn-Signal from my quick test it does seem to work, thanks!

[hiqua]

@EvanHahn-Signal let me know if there's something else I should do before you can merge this.

[EvanHahn-Signal]

Is this something that we want to do?

On Windows, clicking the Discord tray icon doesn't toggle the app—it always shows it. Is this a common pattern on Linux or elsewhere?

[hiqua]

On Windows, clicking the Discord tray icon doesn't toggle the app—it always shows it.

If we're gonna use examples, here are the (very unrepresentative) apps I use (on Linux) and that have a system tray icon. These ones are minimized when I click on the tray icon:

• element-desktop
• qbittorrent
• x2go
• simplescreenrecorder

These ones are focused if on another workspace (i3 workspace, but I guess it's the same with Gnome etc.), minimized if already in focus when I click the tray icon:

• goldendict
• virt-manager

So they all exhibit the behavior of this PR. I don't know about Discord as I only use it from time to time in the browser. But maybe you would prefer the second behavior, meaning:

• if not in focus, get the focus.
• If in focus, minimize the window.
  ?

Is this something that we want to do?

I think there's little drawback in adopting this new behavior: either people don't use it and will not even know about it, or they do and benefit from it.

In terms of impact, I can ask people from the issue to chime in. I've counted 5 users in the issue. Since it's also not such a big bother, I guess there are not that many people who voiced their preference, compared with color-related other issues.

If you're still not convinced, I can open a thread on the forum. The "bug" label on the issue led me to think this was something to be fixed, but maybe it's not?

[Mansarde]

Just wanted to ask if it's possible to distinguish between a single mouse-click and a double-click?
Because there might be many people who double-click on the tray icon to open it, and if the new functionality were to hide the window on a second click, then people who double-click would unintentionally show then instantly hide the window again.

Yeah I know that's more of a PEBCAK problem, but I've seen many people doing this, so it might be good to be mindful of that.
Not saying they ought to be catered to, just throwing it out there. Personally I'm good with the PR and don't mind it either way. 👍

[hiqua]

@Mansarde don't you think they'd just get used to it, and end up doing a single-click eventually? As of now, one click is already enough to open it, right? So you can already see the window when you're doing your second click, if your computer is fast enough.

[Mansarde]

@hiqua I think so too, yes. Didn't mean to say we shouldn't have it because of that. Just wanted to give that perspective which I've watched happen a lot of times, even after they've learned that you usually don't need to double-click.

Personally I don't see a problem with it and am actually for it. :)

[ptandler]

Is this something that we want to do?

On Windows, clicking the Discord tray icon doesn't toggle the app—it always shows it. Is this a common pattern on Linux or elsewhere?

For me on Linux toggling would be the natural thing I would expect, as many other apps do it this way, e.g. Linux Mint's Update Notification, KeePassXC, CopyQ, and many Cinnamon extensions (e.g. notifications).

[indutny-signal]

LGTM. This will be merged with the next beta release. Thank you!