Skip to content

Fix PortAllocator init, especially with flags. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2020
Merged

Fix PortAllocator init, especially with flags. #2

merged 1 commit into from
Apr 28, 2020

Conversation

peter-signal
Copy link
Contributor

No description provided.

jim-signal
jim-signal reviewed Apr 28, 2020
View reviewed changes
p2p/client/basic_port_allocator.cc
// 3. Initialize()
// 4. User setters to set flags and other settings
// 5. SetConfiguration() to set various things.
// The only state this does not replicate are the follwing:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sp

jim-signal
jim-signal approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@jim-signal jim-signal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peter-signal peter-signal merged commit 041988a into signalapp:master Apr 28, 2020
peter-signal pushed a commit that referenced this pull request Jul 18, 2020
@henbos
Reland "Improve outbound-rtp statistics for simulcast"
a0ff50c 
This reverts commit 9a925c9.

Reason for revert: The original CL is updated in PS #2 to
fix the googRtt issue which was that when the legacy sender
stats were put in "aggregated_senders" we forgot to update
rtt_ms the same way that we do it for "senders".

Original change's description:
> Revert "Improve outbound-rtp statistics for simulcast"
>
> This reverts commit da6cda8.
>
> Reason for revert: Breaks googRtt in legacy getStats API
>
> Original change's description:
> > Improve outbound-rtp statistics for simulcast
> >
> > Bug: webrtc:9547
> > Change-Id: Iec4eb976aa11ee743805425bedb77dcea7c2c9be
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168120
> > Reviewed-by: Sebastian Jansson <srte@webrtc.org>
> > Reviewed-by: Erik Språng <sprang@webrtc.org>
> > Reviewed-by: Henrik Boström <hbos@webrtc.org>
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> > Commit-Queue: Eldar Rello <elrello@microsoft.com>
> > Cr-Commit-Position: refs/heads/master@{#31097}
>
> TBR=hbos@webrtc.org,sprang@webrtc.org,stefan@webrtc.org,srte@webrtc.org,hta@webrtc.org,elrello@microsoft.com
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: webrtc:9547
> Change-Id: I06673328c2a5293a7eef03b3aaf2ded9d13df1b3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174443
> Reviewed-by: Henrik Boström <hbos@webrtc.org>
> Commit-Queue: Henrik Boström <hbos@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31165}

TBR=hbos@webrtc.org,sprang@webrtc.org,stefan@webrtc.org,srte@webrtc.org,hta@webrtc.org,elrello@microsoft.com

# Not skipping CQ checks because this is a reland.

Bug: webrtc:9547
Change-Id: I723744c496c3c65f95ab6a8940862c8b9f544338
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174480
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31169}
peter-signal pushed a commit that referenced this pull request Jul 18, 2020
Merge to M84: Log decoder implementation name
b8678c5 
TBR=sprang@webrtc.org
(cherry picked from commit 43c108b)

Bug: chromium:1084963
Change-Id: I2c6b6a2a62bbcd058b8ed336e6e0f36b8b0d0844
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175220
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Original-Commit-Position: refs/heads/master@{#31321}
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175903
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/branch-heads/4147@{#2}
Cr-Branched-From: 2b7d969-refs/heads/master@{#31262}
peter-signal pushed a commit that referenced this pull request Apr 16, 2021
Fix Heap-use-after-free.
fba51dc 
This change fixes a problem where VideoRtpReceiver::OnGenerateKeyFrame would
use it's stored media_channel_ pointer after the channel was deleted. This was
due to the higher layer RtpTransceiver not clearing the reference with SetMediaChannel(nullptr) when removing the receiver, and the VideoRtpReceiver's embedded VideoRtpTrackSource subsequently requesting a key frame.

Note: No-Try to true due to broken trybot ios_sim_x64_dbg_ios10.

TBR=steveanton@webrtc.org,orphis@webrtc.org

(cherry picked from commit 43e62fc)

Bug: chromium:1037703
No-Try: true
Change-Id: Iee8338458063866589b70b4070793fbe600d41ff
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/164538
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Original-Commit-Position: refs/heads/master@{#30175}
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165380
Reviewed-by: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/branch-heads/3987@{#2}
Cr-Branched-From: 1256d9b-refs/heads/master@{#30022}
peter-signal pushed a commit that referenced this pull request Apr 16, 2021
Merge to M81: Make RtpEncodingParameters to not reverse active flags …
e9d668d 
…order

(cherry picked from commit 72859e5)

Bug: webrtc:11319, chromium:1049539
Change-Id: If63db02d282ee622c12405f85c0fbae1ba13fcb2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168196
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Original-Commit-Position: refs/heads/master@{#30459}
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168301
Cr-Commit-Position: refs/branch-heads/4044@{#2}
Cr-Branched-From: be99ee8-refs/heads/master@{#30432}
peter-signal pushed a commit that referenced this pull request Oct 29, 2021
[Merge to 95] Add Direction indicator to TransformableFrames
8d8c0b4 
Currently the implementation of FrameTransformers uses distinct,
incompatible types for recevied vs about-to-be-sent frames. This adds a
flag in the interface so we can at least check that we are being given
the correct type. crbug.com/1250638 tracks removing the need for this.

Chrome will be updated after this to check the direction flag and provide
a javascript error if the wrong type of frame is written into the
encoded insertable streams writable stream, rather than crashing.

(cherry picked from commit 8fb41a3)

Bug: chromium:1247260
Change-Id: I9cbb66962ea0718ed47c5e5dba19a8ff9635b0b1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232301
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Tony Herre <toprice@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#35100}
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233941
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/branch-heads/4638@{#2}
Cr-Branched-From: fb50179-refs/heads/main@{#34960}
rashad-signal pushed a commit that referenced this pull request Jan 3, 2023
@sam-vi
Add an active ICE controller interface (#2/n)
094ee30 
This interface will be implemented by "new" ICE controllers that actively manage the connection used by the transport.

Bug: webrtc:14367, webrtc:14131
Change-Id: I0858884b0decd2a17ae9ca8617a043a085c61d54
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271291
Commit-Queue: Sameer Vijaykar <samvi@google.com>
Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38066}
rashad-signal pushed a commit that referenced this pull request Apr 27, 2023
@fippo @rashad-signal
[M112] Revert "Only serialize non-stopped RTP header extensions"
cb27e79 
This reverts commit be03c09.
Causes regression in web projects that
1/ add a stopped-by-default extension in SRD
2/ call createAnswer
3/ munge the stopped-by-default extension back in SLD
4/ create a subsequent offer and expect the extension to be present

BUG=chromium:1427442,chromium:1051821

Change-Id: I2e48831e92384963a254d873398f54eaee96739a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/299143
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/branch-heads/5615@{#2}
Cr-Branched-From: cdfeb4f-refs/heads/main@{#39376}
inaqui-signal pushed a commit that referenced this pull request Jul 24, 2023
Implement support for Chrome task origin tracing. #2/4
2a256c8 
This prepares TaskQueueBase sub classes to be able to migrate to
the location and traits-based API. It re-introduces a Location class
into the webrtc namespace, which is meant to be overridden by Chromium.

Bug: chromium:1416199
Change-Id: I712c7806a71b3b99b2a2bf95e555b357c21c15ae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/294381
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39400}
inaqui-signal pushed a commit that referenced this pull request Jul 24, 2023
@Pehrsons
[M116] In VideoCaptureImpl and subclasses add thread and lock annotat…
279a054 
…ions

This annotates all unannotated members in VideoCaptureImpl and its
subclasses with either of:
- api_checker_: access on the api thread only
- capture_checker_: access in callbacks/on the capture thread while
                    capture is active, on the api thread otherwise
- a Mutex if it is already protected by it

(cherry picked from commit eee1039)

Bug: webrtc:15181
Change-Id: I5084e7752a4716c29b85a9b403a88696f66d811f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/305647
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Cr-Original-Commit-Position: refs/heads/main@{#40335}
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/310500
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/branch-heads/5845@{#2}
Cr-Branched-From: f80cf81-refs/heads/main@{#40319}
inaqui-signal pushed a commit that referenced this pull request Nov 2, 2023
@fippo
[M118] Obfuscate prflx raddr when using mdns
597e7ba 
BUG=chromium:1478690

(cherry picked from commit a8e3111)

Change-Id: I7a1caad7bbd2fc82507b61b59be71546494a304c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/319580
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Original-Commit-Position: refs/heads/main@{#40724}
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/320580
Cr-Commit-Position: refs/branch-heads/5993@{#2}
Cr-Branched-From: 5afcec0-refs/heads/main@{#40703}
jim-signal pushed a commit that referenced this pull request Jan 19, 2024
@jim-signal
[M120] JsepTransportController: Remove raw pointers to description ob…
96a4ed0 
…jects

Remove member variables that point to objects owned externally (in practice by SdpOfferAnswerHandler). The objects also live on the
signaling thread whereas JsepTransportController performs
operations on the network thread. Removing the raw pointers avoids
the risk of referencing the description objects after they've been
deleted or if the state is inconsistent across threads.

(cherry picked from commit c560520)

Bug: webrtc:1515832
No-Try: true
Change-Id: I852b2a3993964be817f93c46b5bc4b03121cde86
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334061
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Original-Commit-Position: refs/heads/main@{#41505}
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/335180
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/branch-heads/6099@{#2}
Cr-Branched-From: 507f1cc-refs/heads/main@{#41042}
jim-signal pushed a commit that referenced this pull request Jan 19, 2024
@jim-signal
[M120] JsepTransportController: Remove raw pointers to description ob…
7264825 
…jects

Remove member variables that point to objects owned externally (in practice by SdpOfferAnswerHandler). The objects also live on the
signaling thread whereas JsepTransportController performs
operations on the network thread. Removing the raw pointers avoids
the risk of referencing the description objects after they've been
deleted or if the state is inconsistent across threads.

(cherry picked from commit c560520)

Bug: webrtc:1515832
No-Try: true
Change-Id: I852b2a3993964be817f93c46b5bc4b03121cde86
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334061
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Original-Commit-Position: refs/heads/main@{#41505}
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/335180
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/branch-heads/6099@{#2}
Cr-Branched-From: 507f1cc-refs/heads/main@{#41042}
jim-signal pushed a commit that referenced this pull request Feb 7, 2024
@jim-signal
[M120] JsepTransportController: Remove raw pointers to description ob…
5b34746 
…jects

Remove member variables that point to objects owned externally (in practice by SdpOfferAnswerHandler). The objects also live on the
signaling thread whereas JsepTransportController performs
operations on the network thread. Removing the raw pointers avoids
the risk of referencing the description objects after they've been
deleted or if the state is inconsistent across threads.

(cherry picked from commit c560520)

Bug: webrtc:1515832
No-Try: true
Change-Id: I852b2a3993964be817f93c46b5bc4b03121cde86
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334061
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Original-Commit-Position: refs/heads/main@{#41505}
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/335180
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/branch-heads/6099@{#2}
Cr-Branched-From: 507f1cc-refs/heads/main@{#41042}
jim-signal pushed a commit that referenced this pull request Feb 7, 2024
@jim-signal
Revert "[M120] JsepTransportController: Remove raw pointers to descri…
6c485f1 
…ption objects"

This reverts commit e79a99060f70a356b131d9f2f7497914984944d1.

Reason for revert: Merged too early. Will re-land for the next spin.

Original change's description:
> [M120] JsepTransportController: Remove raw pointers to description objects
>
> Remove member variables that point to objects owned externally (in practice by SdpOfferAnswerHandler). The objects also live on the
> signaling thread whereas JsepTransportController performs
> operations on the network thread. Removing the raw pointers avoids
> the risk of referencing the description objects after they've been
> deleted or if the state is inconsistent across threads.
>
> (cherry picked from commit c560520)
>
> Bug: webrtc:1515832
> No-Try: true
> Change-Id: I852b2a3993964be817f93c46b5bc4b03121cde86
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334061
> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Cr-Original-Commit-Position: refs/heads/main@{#41505}
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/335180
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/branch-heads/6099@{#2}
> Cr-Branched-From: 507f1cc-refs/heads/main@{#41042}

Change-Id: Id4bd21fbc8b7306de1aba0854815ada5c9333468
No-Try: true
Bug: chromium:1515832
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/335620
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/branch-heads/6099@{#3}
Cr-Branched-From: 507f1cc-refs/heads/main@{#41042}
jim-signal pushed a commit that referenced this pull request Feb 7, 2024
@jim-signal
Revert^2 "[M120] JsepTransportController: Remove raw pointers to desc…
6d4e716 
…ription objects"

This reverts commit bf2e30678e0e5b21f2a2d49180a13225fdcfaa1a.

Reason for revert: Time to reland the fix for M120 now.

Original change's description:
> Revert "[M120] JsepTransportController: Remove raw pointers to description objects"
>
> This reverts commit e79a99060f70a356b131d9f2f7497914984944d1.
>
> Reason for revert: Merged too early. Will re-land for the next spin.
>
> Original change's description:
> > [M120] JsepTransportController: Remove raw pointers to description objects
> >
> > Remove member variables that point to objects owned externally (in practice by SdpOfferAnswerHandler). The objects also live on the
> > signaling thread whereas JsepTransportController performs
> > operations on the network thread. Removing the raw pointers avoids
> > the risk of referencing the description objects after they've been
> > deleted or if the state is inconsistent across threads.
> >
> > (cherry picked from commit c560520)
> >
> > Bug: webrtc:1515832
> > No-Try: true
> > Change-Id: I852b2a3993964be817f93c46b5bc4b03121cde86
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334061
> > Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> > Cr-Original-Commit-Position: refs/heads/main@{#41505}
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/335180
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Cr-Commit-Position: refs/branch-heads/6099@{#2}
> > Cr-Branched-From: 507f1cc-refs/heads/main@{#41042}
>
> Change-Id: Id4bd21fbc8b7306de1aba0854815ada5c9333468
> No-Try: true
> Bug: chromium:1515832
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/335620
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/branch-heads/6099@{#3}
> Cr-Branched-From: 507f1cc-refs/heads/main@{#41042}

No-Try: true
Bug: chromium:1515832
Change-Id: I13a24182908d7a616234d9c701bf7000a162df8e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/336282
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/branch-heads/6099@{#4}
Cr-Branched-From: 507f1cc-refs/heads/main@{#41042}
jim-signal pushed a commit that referenced this pull request Feb 7, 2024
@jim-signal
[M120] JsepTransportController: Remove raw pointers to description ob…
8ed1707 
…jects

Remove member variables that point to objects owned externally (in practice by SdpOfferAnswerHandler). The objects also live on the
signaling thread whereas JsepTransportController performs
operations on the network thread. Removing the raw pointers avoids
the risk of referencing the description objects after they've been
deleted or if the state is inconsistent across threads.

(cherry picked from commit c560520)

Bug: webrtc:1515832
No-Try: true
Change-Id: I852b2a3993964be817f93c46b5bc4b03121cde86
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334061
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Original-Commit-Position: refs/heads/main@{#41505}
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/335180
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/branch-heads/6099@{#2}
Cr-Branched-From: 507f1cc-refs/heads/main@{#41042}
jim-signal pushed a commit that referenced this pull request Feb 7, 2024
@jim-signal
Revert "[M120] JsepTransportController: Remove raw pointers to descri…
422ca5d 
…ption objects"

This reverts commit e79a99060f70a356b131d9f2f7497914984944d1.

Reason for revert: Merged too early. Will re-land for the next spin.

Original change's description:
> [M120] JsepTransportController: Remove raw pointers to description objects
>
> Remove member variables that point to objects owned externally (in practice by SdpOfferAnswerHandler). The objects also live on the
> signaling thread whereas JsepTransportController performs
> operations on the network thread. Removing the raw pointers avoids
> the risk of referencing the description objects after they've been
> deleted or if the state is inconsistent across threads.
>
> (cherry picked from commit c560520)
>
> Bug: webrtc:1515832
> No-Try: true
> Change-Id: I852b2a3993964be817f93c46b5bc4b03121cde86
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334061
> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Cr-Original-Commit-Position: refs/heads/main@{#41505}
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/335180
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/branch-heads/6099@{#2}
> Cr-Branched-From: 507f1cc-refs/heads/main@{#41042}

Change-Id: Id4bd21fbc8b7306de1aba0854815ada5c9333468
No-Try: true
Bug: chromium:1515832
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/335620
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/branch-heads/6099@{#3}
Cr-Branched-From: 507f1cc-refs/heads/main@{#41042}
jim-signal pushed a commit that referenced this pull request Feb 7, 2024
@jim-signal
Revert^2 "[M120] JsepTransportController: Remove raw pointers to desc…
de3552f 
…ription objects"

This reverts commit bf2e30678e0e5b21f2a2d49180a13225fdcfaa1a.

Reason for revert: Time to reland the fix for M120 now.

Original change's description:
> Revert "[M120] JsepTransportController: Remove raw pointers to description objects"
>
> This reverts commit e79a99060f70a356b131d9f2f7497914984944d1.
>
> Reason for revert: Merged too early. Will re-land for the next spin.
>
> Original change's description:
> > [M120] JsepTransportController: Remove raw pointers to description objects
> >
> > Remove member variables that point to objects owned externally (in practice by SdpOfferAnswerHandler). The objects also live on the
> > signaling thread whereas JsepTransportController performs
> > operations on the network thread. Removing the raw pointers avoids
> > the risk of referencing the description objects after they've been
> > deleted or if the state is inconsistent across threads.
> >
> > (cherry picked from commit c560520)
> >
> > Bug: webrtc:1515832
> > No-Try: true
> > Change-Id: I852b2a3993964be817f93c46b5bc4b03121cde86
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334061
> > Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> > Cr-Original-Commit-Position: refs/heads/main@{#41505}
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/335180
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Cr-Commit-Position: refs/branch-heads/6099@{#2}
> > Cr-Branched-From: 507f1cc-refs/heads/main@{#41042}
>
> Change-Id: Id4bd21fbc8b7306de1aba0854815ada5c9333468
> No-Try: true
> Bug: chromium:1515832
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/335620
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/branch-heads/6099@{#3}
> Cr-Branched-From: 507f1cc-refs/heads/main@{#41042}

No-Try: true
Bug: chromium:1515832
Change-Id: I13a24182908d7a616234d9c701bf7000a162df8e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/336282
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/branch-heads/6099@{#4}
Cr-Branched-From: 507f1cc-refs/heads/main@{#41042}
jim-signal added a commit that referenced this pull request Feb 29, 2024
@jim-signal
Move DISABLE_DEBUG_FLOAT to common config (#2)
f55fb2b 
Makes the binary size for all builds smaller.
jim-signal pushed a commit that referenced this pull request Apr 19, 2024
[M124] Revert "pc: Include SCTP queued bytes in buffered_amount"
93e9ac6 
This breaks file transfers with Chrome Remote Desktop, as reported in
the internal bug tracker.

This reverts commit fea41f5.

Bug: chromium:331346276
Change-Id: Ib41351a474bc40e7688d14dc445f53e68b5833ae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/344501
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/branch-heads/6367@{#2}
Cr-Branched-From: 802552a-refs/heads/main@{#41921}
jim-signal pushed a commit that referenced this pull request Jun 25, 2024
@fippo
[M123] Fix handling of rejected m-lines without transport description
45e49ef 
A fingerprint should not be required for m-lines which are rejected.

BUG=chromium:326493639,webrtc:11066

(cherry picked from commit 845d6be)

Change-Id: I7428c91a144ca46650e13d72868f160652a98339
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/340322
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Original-Commit-Position: refs/heads/main@{#41794}
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/341023
Cr-Commit-Position: refs/branch-heads/6312@{#2}
Cr-Branched-From: 0355f45-refs/heads/main@{#41763}
jim-signal pushed a commit that referenced this pull request Sep 5, 2024
@MirkoBonadei
Fix use-of-uninitialized-value in NetEq tests.
876d0c9 
The new version of MSan (rolled by [1]) detects the following:

```
==39908==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x5591400a52ef in GetPlayoutDelayMs ./../../modules/audio_coding/neteq/decision_logic.cc:466:35
    #1 0x5591400a52ef in webrtc::DecisionLogic::ExpectedPacketAvailable(webrtc::NetEqController::NetEqStatus) ./../../modules/audio_coding/neteq/decision_logic.cc:311:36
    #2 0x5591400a39e9 in webrtc::DecisionLogic::GetDecision(webrtc::NetEqController::NetEqStatus const&, bool*) ./../../modules/audio_coding/neteq/decision_logic.cc:0:0
    #3 0x55913cf590c9 in webrtc::DecisionLogicTest_PreemptiveExpand_Test::TestBody() ./../../modules/audio_coding/neteq/decision_logic_unittest.cc:139:3
    #4 0x55913ef28283 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:3
    #5 0x55913ef28283 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2710:5
    #6 0x55913ef2ab46 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2856:11
    #7 0x55913ef2da34 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3034:30
    #8 0x55913ef621e8 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5964:44
    #9 0x55913ef60f54 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #10 0x55913ef60f54 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5543:10
    #11 0x55913ee1a944 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2334:73
    #12 0x55913ee1a944 in webrtc::(anonymous namespace)::TestMainImpl::Run(int, char**) ./../../test/test_main_lib.cc:203:21
    #13 0x55913cbd36b8 in main ./../../test/test_main.cc:72:16
    #14 0x7fdb18c73082 in __libc_start_main /build/glibc-LcI20x/glibc-2.31/csu/../csu/libc-start.c:308:16
    #15 0x55913cb3e1a9 in _start ??:0:0
```

[1] - https://webrtc-review.googlesource.com/c/src/+/353620

Bug: b/344970813
Change-Id: I9b5d7791e68b4c494168ba9f007a3099ae21fed4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/353581
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Commit-Queue: Jakob Ivarsson‎ <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42433}
jim-signal pushed a commit that referenced this pull request Sep 5, 2024
@grulja
[M128] PipeWire camera: Annotate functions with PipeWire calls to avo…
e768602 
…id CFI

Similar to PipeWire implementation of desktop capture, we have to avoid
CFI check for calls of dlopened PipeWire library. This avoid crashing
PipeWire camera backend when "is_official_build=true" option is used as
this turns on "is_cfi=true" enabling control flow integrity.

iOS bots are broken due to xcode version mismatch. But the change is linux-only, so they are irrelevant. Disabling presubmit checks.

(cherry picked from commit 9e755f0)

No-Try: true
Bug: chromium:354776214
Change-Id: I7a9fc1c2d77c4ee0e8fe0586369b7246e0bb9180
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358103
Commit-Queue: Jan Grulich <grulja@gmail.com>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#42706}
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359162
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Jan Grulich <grulja@gmail.com>
Cr-Commit-Position: refs/branch-heads/6613@{#2}
Cr-Branched-From: 1ac162e-refs/heads/main@{#42664}
jim-signal pushed a commit that referenced this pull request Oct 24, 2024
@henbos
[Merge-130] Fix LibvpxVp9Encoder simulcast bug.
28b793b 
As of [1], a single VP9 encoder instance can produce simulcast 4:2:1.
When it does, the EncodedImage has its simulcast index set (0, 1, 2).

The bug is that if you then go back to a single encoder instance,
either because you're doing singlecast or because you're doing
simulcast with scaling factors that are not power of two (not 4:2:1),
then the simulcast index which was previously set to 2 is not reset due
to the old code path never calling SetSimulcastIndex.

Example repro:
1. Send VP9 simulcast {180p, 360p, 720p}, i.e. 4:2.1.
2. Reconfigure to {180p, 360p, 540p}, i.e. no longer 4:2:1.

What should happen: all three layers are sent.
What actually happened: 180p is not sent and the 540p layer flips flops
between 180p and 540p because the EncodedImage says simulcast index is
2 for both encodings[0] and encodings[2].

The fix is a one-line change: `SetSimulcastIndex(std::nullopt)` in the
case that we don't have a `simulcast_to_svc_converter_` that sets it
(0, 1, 2) for us.

[1] https://webrtc-review.googlesource.com/c/src/+/360280

(cherry picked from commit a6fbb35)

Bug: chromium:370299916
Change-Id: I94ce1a0bde43ef56cba930cb69b744877bbd4bf9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/363941
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Original-Commit-Position: refs/heads/main@{#43109}
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/364302
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/branch-heads/6723@{#2}
Cr-Branched-From: 13e377b-refs/heads/main@{#43019}
mutexlox-signal pushed a commit that referenced this pull request Jan 15, 2025
[M132 merge] Avoid potential deadlock due to queue in corruption dete…
18db2ca 
…ction.

In particular, some platforms have a limited pool of frames in the
capturer stack, so we need to avoid stashing raw frames in the frame
instrumentation generator that may be dropped by limiting the size of
the queue and avoid putting anything in there until we know we will
send it to the encoder.

(cherry picked from commit 9aeed0c)

Bug: webrtc:358039777, chromium:380095413
Change-Id: I054ae53dd5e6ac6a22da39c5049f47788561e77a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/368641
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Original-Commit-Position: refs/heads/main@{#43432}
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/368901
Cr-Commit-Position: refs/branch-heads/6834@{#2}
Cr-Branched-From: a5d7100-refs/heads/main@{#43387}
jim-signal pushed a commit that referenced this pull request Apr 7, 2025
@eshrubs
Deflake VP9_SimulcastDeactiveActiveLayer_StandardSvc
934c983 
Two fixes to deflake,

1. Increase the ramp up time for all layers - short time was flaky for
   720p.

2. Wait for both the scalability mode AND implementation name to update.
   Sometimes the implementation name would change before the scalability
   mode did due to a race, so some OutboundRtpStats would have the wrong
   values.

To achieve #2 (and #1 with some debugging) a new utility
WaitForCondition was added in order to apply matchers to a condition.
This is used instead of EXPECT_WAIT_EQ and similar because it gives
clear feedback on failure.

I have made 500 runs without a further flake.

Bug: webrtc:381216372
Change-Id: I0132377774e379857664e9a0c20f432bc9dc9fb7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/369742
Reviewed-by: Olga Sharonova <olka@webrtc.org>
Commit-Queue: Olga Sharonova <olka@webrtc.org>
Auto-Submit: Evan Shrubsole <eshr@google.com>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43472}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-signal jim-signal jim-signal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peter-signal @jim-signal