Temporarily add a no-op flag --metrics-addr #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
add-a-noop-metrics-addr
branch
from
70df520 to
9903ef4
Compare
atoulme
approved these changes
Dec 15, 2022
|
The build fails because of an issue that has been fixed in main. You can rebase or merge directly. |
This attribute is temporarily required to be set to make Splunk OTel Collector Helm chart to work on GKE/Autopilot.
atoulme
force-pushed
the
add-a-noop-metrics-addr
branch
from
9903ef4 to
220e320
Compare
|
Rebased. |
|
@atoulme, still fails. Is this good to merge? |
|
Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attribute is temporarily required to be set to make Splunk OTel Collector Helm chart to work on GKE/Autopilot.