Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial token auth scope end-to-end tests #423

Merged
merged 3 commits into from
Jun 8, 2021
Merged

Initial token auth scope end-to-end tests #423

merged 3 commits into from
Jun 8, 2021

Conversation

rmfitzpatrick
Copy link
Contributor

@rmfitzpatrick rmfitzpatrick commented May 20, 2021

Requires: #363

Adds initial end-to-end test to verify that postgres SA monitor and SFx event exporters work w/ specific token auth scopes. Gist is that API-only auth scope is not compatible w/ metric and metadata-producing clients like the Collector and triggers 401s without producing any data, but any Ingest auth scope provided token should work without 401s.

These changes also add a uuid to each test case, add SPLUNK_ env var support for testcase Collector instances, and include an unrelated flake fix.

Ryan Fitzpatrick added 2 commits June 1, 2021 18:44

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@rmfitzpatrick rmfitzpatrick changed the base branch from docker_integration_tests to main June 1, 2021 20:07
Copy link
Contributor

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Do we plan to run the tests in Gitlab?

@@ -44,7 +44,6 @@ resource_metrics:
- name: gauge.kafka.produce.total-time.99th
type: IntGauge
- name: gauge.kafka.produce.total-time.median
type: IntGauge
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this removal intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's reported as an int gauge when 0 and a double gauge when not, so relaxing is necessary to reduce flake. oneof() isn't supported yet.

@@ -154,7 +165,7 @@ func (collector CollectorContainer) buildContextArchive() (io.Reader, error) {

dockerfile += `
COPY config.yaml /etc/config.yaml
ENV SPLUNK_CONFIG=/etc/config.yaml
# ENV SPLUNK_CONFIG=/etc/config.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why commented out?

Copy link
Contributor Author

@rmfitzpatrick rmfitzpatrick Jun 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's currently forbidden to use both the env var and the --config option*: #450

@rmfitzpatrick
Copy link
Contributor Author

Nice! Do we plan to run the tests in Gitlab?

Yes, this would be ideal. Will sync with you and @jcheng-splunk for help w/ this.

@rmfitzpatrick rmfitzpatrick merged commit 2f57340 into main Jun 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the e2e branch June 8, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants