Allow setting both SPLUNK_CONFIG and --config with priority given to --config #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
requested review from
pmcollins,
jrcamp,
flands,
dmitryax,
mstumpfx,
bjsignalfx and
jeffreyc-splunk
pmcollins
approved these changes
Jun 3, 2021
rmfitzpatrick
force-pushed
the
start_env_var_fixup
branch
from
626e348 to
d4e4b27
Compare
|
@flands, mind weighing in as the original author? |
rmfitzpatrick
force-pushed
the
start_env_var_fixup
branch
from
d4e4b27 to
3aa5146
Compare
bjsignalfx
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's forbidden to set both
SPLUNK_CONFIGand provide the--configcmdline options for our distribution. This is a little unexpected given cli tools generally allow redundant options while giving priority to command line options and falling back to environment variables. The current system makes it relatively inconvenient to update startup arguments as changing or clearing the environment variable is also required, which can sometimes be more difficult than updating the cmdline args.These changes ease the restriction and give priority to the
--configoption with clear logging of which config will be used. They also provide more context when default config locations are used and required env vars aren't set.Also including necessary testutils changes for added integration tests.