default vc to block v3 endpoint and deprecate block-v3 flag #5292

eserilev · 2024-02-25T12:55:45Z

Issue Addressed

Closes #5040

Proposed Changes

Deprecate the produce-block-v3 flag, and use the v3 endpoint by default within the VC

This should only be merged after deneb is safely activated.

dapplion

LGTM

michaelsproul · 2024-03-06T22:44:54Z

I think we should wait until after v5.1.0 for this one

michaelsproul · 2024-04-29T04:38:48Z

Looks like we'll be OK to merge this for v5.2.0. There was a bug in Nimbus's v3 implementation prior to v24.4.0, which is due imminently:

status-im/nimbus-eth2@f20a21c

Bug:

produceBlockV3 call should send execution_payload_blinded value as boolean. status-im/nimbus-eth2#6204

We should call this out in the release notes so that users running Nimbus BNs know they need to upgrade.

I'm doing some more testing with other BNs and blockdreamer.

…fault-vc-to-block-v3-endpoint

michaelsproul · 2024-04-30T07:09:39Z

Idk about this. My Teku testing got blocked by a bug on their side involving eleel which I haven't had time to fix.

Let's just drop it from v5.2.0 for now so we can get moving.

michaelsproul

LGTM. Nice simplification.

michaelsproul · 2024-07-18T04:24:04Z

@mergify queue

mergify · 2024-07-18T04:24:14Z

queue

🛑 The pull request has been removed from the queue `default`

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

michaelsproul · 2024-07-18T07:23:36Z

I'm not sure why the fallback simulator is failing. Haven't had a chance to investigate

jimmygchen · 2024-07-25T04:20:41Z

It looks like the BNs had some issues with getting payload from the EL. I've re-run the job to check if it's just a flaky error:

2024-07-22T19:21:17.0428622Z Jul 22 19:21:17.017 ERRO Error whilst producing block            info: block v3 proposal failed, this error may or may not result in a missed block, block_slot: Slot(110), error: "Error from beacon node when producing block: Recoverable(\"Error from beacon node when producing block: ServerMessage(ErrorMessage { code: 400, message: \\\"BAD_REQUEST: failed to fetch a block: GetPayloadFailed(EngineError(Api { error: PayloadIdUnavailable }))\\\", stacktraces: [] })\")", service: block, service: validator_2

jimmygchen · 2024-07-25T04:45:45Z

validator_client/src/block_service.rs

@@ -584,7 +511,7 @@ impl<T: SlotClock + 'static, E: EthSpec> BlockService<T, E> {
                        &metrics::BLOCK_SERVICE_TIMES,
                        &[metrics::BEACON_BLOCK_HTTP_GET],
                    );
-                    let block_response = Self::get_validator_block_v3(
+                    let block_response = Self::get_validator_block(


Not part of this PR, I think it may be unnecessary to re-map the BlockError here?

https://github.com/sigp/lighthouse/pull/5292/files#diff-9397634273d7e6a89631ace49f8f1cfe7f083db2b556f1dee86b76184b7618e6R524-R529

jimmygchen · 2024-07-25T04:54:46Z

Oh I think the fallback is not working because we're always returning an Ok here instead of returning the result:

lighthouse/validator_client/src/block_service.rs

Line 531 in 0201119

Ok::<_, BlockError>(block_response)

…fault-vc-to-block-v3-endpoint

testing/simulator/src/cli.rs

eserilev · 2024-07-26T01:27:50Z

thanks @jimmygchen! That seems to have fixed it (locally at least). The job failed in CI but maybe its just flaky? ill retry later when I'm at my computer

jimmygchen

Nice, green CI now 🎉

jimmygchen · 2024-07-26T05:21:37Z

@mergify queue

mergify · 2024-07-26T05:21:58Z

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at f60503c

default vc to block v3 endpoint and deprecate block-v3 flag

3ea8476

dapplion approved these changes Feb 27, 2024

View reviewed changes

dapplion added the ready-for-review The code is ready for review label Feb 27, 2024

michaelsproul added the backwards-incompat Backwards-incompatible API change label Mar 6, 2024

michaelsproul added the blocked label Mar 6, 2024

eserilev added v5.2.0 Q2 2024 and removed blocked labels Mar 31, 2024

kick off ci

15b4ff7

realbigsean added 3 commits April 29, 2024 15:03

Merge branch 'unstable' of https://github.com/sigp/lighthouse into de…

6c76e03

…fault-vc-to-block-v3-endpoint

fix formatting in cli docs

82d6976

Merge branch 'unstable' of https://github.com/sigp/lighthouse into de…

2d0f7c4

…fault-vc-to-block-v3-endpoint

michaelsproul added val-client Relates to the validator client binary under-review A reviewer has only partially completed a review. and removed v5.2.0 Q2 2024 ready-for-review The code is ready for review labels Apr 30, 2024

michaelsproul added the v5.3.0 Q3 2024 release with database changes! label Jul 15, 2024

eserilev added 2 commits July 16, 2024 23:38

Resolve merge conflicts

0201119

resolve conflicts

43344ad

michaelsproul added ready-for-merge This PR is ready to merge. and removed under-review A reviewer has only partially completed a review. labels Jul 18, 2024

michaelsproul approved these changes Jul 18, 2024

View reviewed changes

mergify bot added a commit that referenced this pull request Jul 18, 2024

Merge of #5292

cc8cd47

mergify bot mentioned this pull request Jul 18, 2024

merge queue: embarking unstable (7afb230) and #5292 together #6126

Closed

5 tasks

michaelsproul removed the ready-for-merge This PR is ready to merge. label Jul 18, 2024

michaelsproul added the blocked label Jul 18, 2024

eserilev force-pushed the default-vc-to-block-v3-endpoint branch from 22fda71 to 43344ad Compare July 22, 2024 04:20

eserilev added 6 commits July 21, 2024 21:21

merge

20c5141

merge

c62e7cf

revert

87ee4e7

retry

b2b987f

fix

394fd54

Merge branch 'unstable' into default-vc-to-block-v3-endpoint

3efc8a3

jimmygchen reviewed Jul 25, 2024

View reviewed changes

jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed blocked labels Jul 25, 2024

eserilev added 2 commits July 25, 2024 16:53

Merge branch 'unstable' of https://github.com/sigp/lighthouse into de…

50d5885

…fault-vc-to-block-v3-endpoint

fix issues w/ fallback sim

357d257

eserilev commented Jul 26, 2024

View reviewed changes

testing/simulator/src/cli.rs Show resolved Hide resolved

jimmygchen approved these changes Jul 26, 2024

View reviewed changes

jimmygchen added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jul 26, 2024

mergify bot added a commit that referenced this pull request Jul 26, 2024

Merge of #5292

a843785

This was referenced Jul 26, 2024

merge queue: embarking unstable (b949db0) and [#5292 + #6190] together #6191

Closed

Use upgradable read lock for pubkey cache #6190

Merged

mergify bot merged commit f60503c into sigp:unstable Jul 26, 2024
29 checks passed

jimmygchen mentioned this pull request Jul 26, 2024

Switch to block v3 by default in VC #5040

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

default vc to block v3 endpoint and deprecate block-v3 flag #5292

default vc to block v3 endpoint and deprecate block-v3 flag #5292

eserilev commented Feb 25, 2024 •

edited by dapplion

Loading

dapplion left a comment

michaelsproul commented Mar 6, 2024 •

edited

Loading

michaelsproul commented Apr 29, 2024 •

edited

Loading

michaelsproul commented Apr 30, 2024

michaelsproul left a comment

michaelsproul commented Jul 18, 2024

mergify bot commented Jul 18, 2024 •

edited

Loading

michaelsproul commented Jul 18, 2024

jimmygchen commented Jul 25, 2024

jimmygchen Jul 25, 2024

jimmygchen commented Jul 25, 2024

eserilev commented Jul 26, 2024

jimmygchen left a comment

jimmygchen commented Jul 26, 2024

mergify bot commented Jul 26, 2024 •

edited

Loading

default vc to block v3 endpoint and deprecate block-v3 flag #5292

default vc to block v3 endpoint and deprecate block-v3 flag #5292

Conversation

eserilev commented Feb 25, 2024 • edited by dapplion Loading

Issue Addressed

Proposed Changes

dapplion left a comment

Choose a reason for hiding this comment

michaelsproul commented Mar 6, 2024 • edited Loading

michaelsproul commented Apr 29, 2024 • edited Loading

michaelsproul commented Apr 30, 2024

michaelsproul left a comment

Choose a reason for hiding this comment

michaelsproul commented Jul 18, 2024

mergify bot commented Jul 18, 2024 • edited Loading

🛑 The pull request has been removed from the queue default

michaelsproul commented Jul 18, 2024

jimmygchen commented Jul 25, 2024

jimmygchen Jul 25, 2024

Choose a reason for hiding this comment

jimmygchen commented Jul 25, 2024

eserilev commented Jul 26, 2024

jimmygchen left a comment

Choose a reason for hiding this comment

jimmygchen commented Jul 26, 2024

mergify bot commented Jul 26, 2024 • edited Loading

✅ The pull request has been merged automatically

eserilev commented Feb 25, 2024 •

edited by dapplion

Loading

michaelsproul commented Mar 6, 2024 •

edited

Loading

michaelsproul commented Apr 29, 2024 •

edited

Loading

mergify bot commented Jul 18, 2024 •

edited

Loading

🛑 The pull request has been removed from the queue `default`

mergify bot commented Jul 26, 2024 •

edited

Loading