Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

produceBlockV3 call should send execution_payload_blinded value as boolean. #6204

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

cheatfate
Copy link
Contributor

This PR should fix #6176

else:
writer.writeField("execution_payload_blinded", "false")
writer.writeField("execution_payload_blinded", false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could one replace the whole thing with writer.writeField("execution_payload_blinded", isBlinded) at this point? it doesn't seem like the conditional adds anything.

Copy link

Unit Test Results

         9 files  ±0    1 115 suites  ±0   27m 42s ⏱️ - 6m 37s
  4 245 tests ±0    3 898 ✔️ ±0  347 💤 ±0  0 ±0 
16 929 runs  ±0  16 531 ✔️ ±0  398 💤 ±0  0 ±0 

Results for commit d37a4dd. ± Comparison against base commit c57fcb4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants