Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

produceBlockV3 call should send execution_payload_blinded value as boolean. #6204

Merged
merged 2 commits into from
Apr 15, 2024
Merged

produceBlockV3 call should send execution_payload_blinded value as boolean. #6204

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af9da73
Fix `execution_payload_blinded` in produceBlockV3 response should be …
cheatfate Apr 15, 2024
d37a4dd
Address review comments.
cheatfate Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions beacon_chain/spec/eth2_apis/eth2_rest_serialization.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3404,9 +3404,9 @@ proc writeValue*(writer: var JsonWriter[RestJson],
withForkyMaybeBlindedBlck(value):
writer.writeField("version", consensusFork.toString())
when isBlinded:
writer.writeField("execution_payload_blinded", "true")
writer.writeField("execution_payload_blinded", true)
else:
writer.writeField("execution_payload_blinded", "false")
writer.writeField("execution_payload_blinded", false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could one replace the whole thing with writer.writeField("execution_payload_blinded", isBlinded) at this point? it doesn't seem like the conditional adds anything.

if value.executionValue.isSome():
writer.writeField("execution_payload_value",
$(value.executionValue.get()))
Expand Down
Loading